third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp ('k') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 85 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
96 Member<LocalFrame> m_frame;	96 Member<LocalFrame> m_frame;

97 Member<Range> m_compositionRange;	97 Member<Range> m_compositionRange;

98 bool m_isDirty;	98 bool m_isDirty;

99 bool m_hasComposition;	99 bool m_hasComposition;

100	100

101 explicit InputMethodController(LocalFrame&);	101 explicit InputMethodController(LocalFrame&);

102	102

103 Editor& editor() const;	103 Editor& editor() const;

104 LocalFrame& frame() const	104 LocalFrame& frame() const

105 {	105 {

106 ASSERT(m_frame);	106 DCHECK(m_frame);

107 return *m_frame;	107 return *m_frame;

108 }	108 }

109	109

110 String composingText() const;	110 String composingText() const;

111 bool insertTextForConfirmedComposition(const String& text);	111 bool insertTextForConfirmedComposition(const String& text);

112 void selectComposition() const;	112 void selectComposition() const;

113 bool setSelectionOffsets(const PlainTextRange&);	113 bool setSelectionOffsets(const PlainTextRange&);

114 };	114 };

115	115

116 } // namespace blink	116 } // namespace blink

117	117

118 #endif // InputMethodController_h	118 #endif // InputMethodController_h

OLD	NEW