ASSERT -> DCHECK in core/editing.

third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 24 matching lines @@
 {
     for (Node* runner = node; runner; runner = FlatTreeTraversal::parent(*runner)) {
         if (isShadowHost(runner))
             return runner;
     }
     return nullptr;
 }
 
 bool isEnclosedBy(const PositionInFlatTree& position, const Node& node)
 {
-    ASSERT(position.isNotNull());
+    DCHECK(position.isNotNull());
     Node* anchorNode = position.anchorNode();
     if (anchorNode == node)
         return !position.isAfterAnchor() && !position.isBeforeAnchor();
 
     return FlatTreeTraversal::isDescendantOf(*anchorNode, node);
 }
 
 bool isSelectionBoundary(const Node& node)
 {
     return isHTMLTextAreaElement(node) || isHTMLInputElement(node) || isHTMLSelectElement(node);
@@ skipping 38 matching lines @@
     // and selection painting uses anchor nodes.
     if (Node* firstChild = FlatTreeTraversal::firstChild(*shadowHost))
         return PositionInFlatTree::beforeNode(firstChild);
     return PositionInFlatTree();
 }
 
 Position adjustPositionForEnd(const Position& currentPosition, Node* startContainerNode)
 {
     TreeScope& treeScope = startContainerNode->treeScope();
 
-    ASSERT(currentPosition.computeContainerNode()->treeScope() != treeScope);
+    DCHECK(currentPosition.computeContainerNode()->treeScope() != treeScope);
 
     if (Node* ancestor = treeScope.ancestorInThisScope(currentPosition.computeContainerNode())) {
         if (ancestor->contains(startContainerNode))
             return positionAfterNode(ancestor);
         return positionBeforeNode(ancestor);
     }
 
     if (Node* lastChild = treeScope.rootNode().lastChild())
         return positionAfterNode(lastChild);
 
@@ skipping 13 matching lines @@
     // and selection painting uses anchor nodes.
     if (Node* lastChild = FlatTreeTraversal::lastChild(*shadowHost))
         return PositionInFlatTree::afterNode(lastChild);
     return PositionInFlatTree();
 }
 
 Position adjustPositionForStart(const Position& currentPosition, Node* endContainerNode)
 {
     TreeScope& treeScope = endContainerNode->treeScope();
 
-    ASSERT(currentPosition.computeContainerNode()->treeScope() != treeScope);
+    DCHECK(currentPosition.computeContainerNode()->treeScope() == treeScope);

[yosin_UTC9, 2016/04/12 01:45:23]

s/==/!=/

This is the reason of webkit_unit_tests failures.

[kotenkov, 2016/04/12 06:05:24]

Thanks for catching this!

 
     if (Node* ancestor = treeScope.ancestorInThisScope(currentPosition.computeContainerNode())) {
         if (ancestor->contains(endContainerNode))
             return positionBeforeNode(ancestor);
         return positionAfterNode(ancestor);
     }
 
     if (Node* firstChild = treeScope.rootNode().firstChild())
         return positionBeforeNode(firstChild);
 
@@ skipping 75 matching lines @@
         selection->m_start = position2;
         selection->m_end = position1;
     }
     selection->updateSelectionType();
     selection->didChange();
 }
 
 void SelectionAdjuster::adjustSelectionToAvoidCrossingShadowBoundaries(VisibleSelection* selection)
 {
     // Note: |m_selectionType| isn't computed yet.
-    ASSERT(selection->base().isNotNull());
-    ASSERT(selection->extent().isNotNull());
-    ASSERT(selection->start().isNotNull());
-    ASSERT(selection->end().isNotNull());
+    DCHECK(selection->base().isNotNull());
+    DCHECK(selection->extent().isNotNull());
+    DCHECK(selection->start().isNotNull());
+    DCHECK(selection->end().isNotNull());
 
     // TODO(hajimehoshi): Checking treeScope is wrong when a node is
     // distributed, but we leave it as it is for backward compatibility.
     if (selection->start().anchorNode()->treeScope() == selection->end().anchorNode()->treeScope())
         return;
 
     if (selection->isBaseFirst()) {
         const Position& newEnd = adjustPositionForEnd(selection->end(), selection->start().computeContainerNode());
         selection->m_extent = newEnd;
         selection->m_end = newEnd;
@@ skipping 22 matching lines @@
         selection->m_end = newEnd;
         return;
     }
     Node* const shadowHost = shadowHostEnd ? shadowHostEnd : shadowHostStart;
     const PositionInFlatTree& newStart = adjustPositionInFlatTreeForStart(selection->start(), shadowHost);
     selection->m_extent = newStart;
     selection->m_start = newStart;
 }
 
 } // namespace blink