Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
index 93189a04f86db3987aa8a1f415e3cbc02d583f41..a90e2b8a9ba48ff18350582caf9609b91b586c8d 100644
--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
@@ -97,7 +97,7 @@ void SelectionEditor::setVisibleSelection(const VisibleSelection& newSelection,
void SelectionEditor::setVisibleSelection(const VisibleSelectionInFlatTree& newSelection, FrameSelection::SetSelectionOptions options)
{
- ASSERT(!(options & FrameSelection::DoNotAdjustInFlatTree));
+ DCHECK(!(options & FrameSelection::DoNotAdjustInFlatTree));
m_selectionInFlatTree = newSelection;
SelectionAdjuster::adjustSelectionInDOMTree(&m_selection, m_selectionInFlatTree);
}
@@ -863,7 +863,7 @@ DispatchEventResult SelectionEditor::dispatchSelectStart()
void SelectionEditor::didChangeVisibleSelection()
{
- ASSERT(m_observingVisibleSelection);
+ DCHECK(m_observingVisibleSelection);
// Invalidate the logical range when the underlying VisibleSelection has changed.
if (m_logicalRange) {
m_logicalRange->dispose();
@@ -875,7 +875,7 @@ void SelectionEditor::didChangeVisibleSelection()
void SelectionEditor::startObservingVisibleSelectionChange()
{
- ASSERT(!m_observingVisibleSelection);
+ DCHECK(!m_observingVisibleSelection);
m_selection.setChangeObserver(*this);
m_observingVisibleSelection = true;
}

Powered by Google App Engine
This is Rietveld 408576698