third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

index e3576d69f8eb423b06e73260fa88b8a47178ba29..712740f04bdad1271a0a19689c377a5478c4773d 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

@@ -37,14 +37,14 @@ DeleteFromTextNodeCommand::DeleteFromTextNodeCommand(Text* node, unsigned offset

, m_offset(offset)

, m_count(count)

{

- ASSERT(m_node);

- ASSERT(m_offset <= m_node->length());

- ASSERT(m_offset + m_count <= m_node->length());

+ DCHECK(m_node);

+ DCHECK_LE(m_offset, m_node->length());

+ DCHECK_LE(m_offset + m_count, m_node->length());

}

void DeleteFromTextNodeCommand::doApply(EditingState*)

{

- ASSERT(m_node);

+ DCHECK(m_node);

if (!m_node->isContentEditable(Node::UserSelectAllIsAlwaysNonEditable))

return;

@@ -59,7 +59,7 @@ void DeleteFromTextNodeCommand::doApply(EditingState*)

void DeleteFromTextNodeCommand::doUnapply()

{

- ASSERT(m_node);

+ DCHECK(m_node);

if (!m_node->hasEditableStyle())

return;