third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/BackwardsTextBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp

index 338de628f37ea7695760042a772edd6ee041419f..2d6f8bb3f7a3abbeda55859288f6aa43fd0d9160 100644

--- a/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp

@@ -47,7 +47,7 @@ PositionTemplate<Strategy> BackwardsCharacterIteratorAlgorithm<Strategy>::endPos

Node* n = m_textIterator.startContainer();

return PositionTemplate<Strategy>::editingPositionOf(n, m_textIterator.endOffset() - m_runOffset);

}

- ASSERT(!m_runOffset);

+ DCHECK(!m_runOffset);

}

return m_textIterator.endPosition();

}

@@ -56,7 +56,7 @@ template <typename Strategy>

void BackwardsCharacterIteratorAlgorithm<Strategy>::advance(int count)

{

if (count <= 0) {

- ASSERT(!count);

+ DCHECK(!count);

return;

}