third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h b/third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h

index 28d0a6a383dfea382b3e2cf8df13917b6d001e74..95a0624fbf42519f521ed9120348b19f0ea5edcf 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h

+++ b/third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h

@@ -19,7 +19,7 @@ public:

size_t size() const { return m_size; }

bool isEmpty() const { return m_size == 0; }

size_t capacity() const { return m_buffer.capacity(); }

- const UChar& operator[](size_t index) const { ASSERT(index < m_size); return data()[index]; }

+ const UChar& operator[](size_t index) const { DCHECK_LT(index, m_size); return data()[index]; }

virtual const UChar* data() const = 0;

void pushCharacters(UChar, size_t length);