third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp b/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp

index 96caeb507e47e068382f7dad12433a80ebdd10bb..36ac9fb7c0278a81a52c4c4843cb491c3b2fa3d5 100644

--- a/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp

+++ b/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp

@@ -77,7 +77,7 @@ void GranularityStrategyTest::SetUp()

{

m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600));

m_document = toHTMLDocument(&m_dummyPageHolder->document());

- ASSERT(m_document);

+ DCHECK(m_document);

dummyPageHolder().frame().settings()->setDefaultFontSize(12);

dummyPageHolder().frame().settings()->setSelectionStrategy(SelectionStrategy::Direction);

}