third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

index f896196fe29287bdd544acb4d415f52dccf9c603..6bfa30124805f13066fc89e166e864deefcf8a92 100644

--- a/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp

@@ -35,14 +35,14 @@ namespace blink {

SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand(Text* text, int offset)

: CompositeEditCommand(text->document()), m_text(text), m_offset(offset)

{

- ASSERT(m_text);

- ASSERT(m_text->length() > 0);

+ DCHECK(m_text);

+ DCHECK_GT(m_text->length(), 0u);

}

void SplitTextNodeContainingElementCommand::doApply(EditingState*)

{

- ASSERT(m_text);

- ASSERT(m_offset > 0);

+ DCHECK(m_text);

+ DCHECK_GT(m_offset, 0);

splitTextNode(m_text.get(), m_offset);