Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
index 0581ae6d82eb430280e91df1da815eb52037dced..34503914db9c4813705128739b2ea907ad870f40 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
@@ -38,8 +38,8 @@ EditCommand::EditCommand(Document& document)
: m_document(&document)
, m_parent(nullptr)
{
- ASSERT(m_document);
- ASSERT(m_document->frame());
+ DCHECK(m_document);
+ DCHECK(m_document->frame());
setStartingSelection(m_document->frame()->selection().selection());
setEndingSelection(m_startingSelection);
}
@@ -64,7 +64,7 @@ void EditCommand::setStartingSelection(const VisibleSelection& selection)
{
for (EditCommand* command = this; ; command = command->m_parent) {
if (EditCommandComposition* composition = compositionIfPossible(command)) {
- ASSERT(command->isTopLevelCommand());
+ DCHECK(command->isTopLevelCommand());
composition->setStartingSelection(selection);
}
command->m_startingSelection = selection;
@@ -77,7 +77,7 @@ void EditCommand::setEndingSelection(const VisibleSelection& selection)
{
for (EditCommand* command = this; command; command = command->m_parent) {
if (EditCommandComposition* composition = compositionIfPossible(command)) {
- ASSERT(command->isTopLevelCommand());
+ DCHECK(command->isTopLevelCommand());
composition->setEndingSelection(selection);
}
command->m_endingSelection = selection;
@@ -93,7 +93,7 @@ bool EditCommand::isRenderedCharacter(const Position& position)
{
if (position.isNull())
return false;
- ASSERT(position.isOffsetInAnchor());
+ DCHECK(position.isOffsetInAnchor()) << position;
if (!position.anchorNode()->isTextNode())
return false;
@@ -106,8 +106,8 @@ bool EditCommand::isRenderedCharacter(const Position& position)
void EditCommand::setParent(CompositeEditCommand* parent)
{
- ASSERT((parent && !m_parent) || (!parent && m_parent));
- ASSERT(!parent || !isCompositeEditCommand() || !toCompositeEditCommand(this)->composition());
+ DCHECK((parent && !m_parent) || (!parent && m_parent));
+ DCHECK(!parent || !isCompositeEditCommand() || !toCompositeEditCommand(this)->composition());
m_parent = parent;
if (parent) {
m_startingSelection = parent->m_endingSelection;

Powered by Google App Engine
This is Rietveld 408576698