Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 17 matching lines...) Expand all
28 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 28 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
29 #include "core/editing/commands/ApplyStyleCommand.h" 29 #include "core/editing/commands/ApplyStyleCommand.h"
30 #include "core/html/HTMLSpanElement.h" 30 #include "core/html/HTMLSpanElement.h"
31 31
32 namespace blink { 32 namespace blink {
33 33
34 WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand(Element* element) 34 WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand(Element* element)
35 : SimpleEditCommand(element->document()) 35 : SimpleEditCommand(element->document())
36 , m_element(element) 36 , m_element(element)
37 { 37 {
38 ASSERT(m_element); 38 DCHECK(m_element);
39 } 39 }
40 40
41 void WrapContentsInDummySpanCommand::executeApply() 41 void WrapContentsInDummySpanCommand::executeApply()
42 { 42 {
43 NodeVector children; 43 NodeVector children;
44 getChildNodes(*m_element, children); 44 getChildNodes(*m_element, children);
45 45
46 for (auto& child : children) 46 for (auto& child : children)
47 m_dummySpan->appendChild(child.release(), IGNORE_EXCEPTION); 47 m_dummySpan->appendChild(child.release(), IGNORE_EXCEPTION);
48 48
49 m_element->appendChild(m_dummySpan.get(), IGNORE_EXCEPTION); 49 m_element->appendChild(m_dummySpan.get(), IGNORE_EXCEPTION);
50 } 50 }
51 51
52 void WrapContentsInDummySpanCommand::doApply(EditingState*) 52 void WrapContentsInDummySpanCommand::doApply(EditingState*)
53 { 53 {
54 m_dummySpan = HTMLSpanElement::create(document()); 54 m_dummySpan = HTMLSpanElement::create(document());
55 55
56 executeApply(); 56 executeApply();
57 } 57 }
58 58
59 void WrapContentsInDummySpanCommand::doUnapply() 59 void WrapContentsInDummySpanCommand::doUnapply()
60 { 60 {
61 ASSERT(m_element); 61 DCHECK(m_element);
62 62
63 if (!m_dummySpan || !m_element->hasEditableStyle()) 63 if (!m_dummySpan || !m_element->hasEditableStyle())
64 return; 64 return;
65 65
66 NodeVector children; 66 NodeVector children;
67 getChildNodes(*m_dummySpan, children); 67 getChildNodes(*m_dummySpan, children);
68 68
69 for (auto& child : children) 69 for (auto& child : children)
70 m_element->appendChild(child.release(), IGNORE_EXCEPTION); 70 m_element->appendChild(child.release(), IGNORE_EXCEPTION);
71 71
72 m_dummySpan->remove(IGNORE_EXCEPTION); 72 m_dummySpan->remove(IGNORE_EXCEPTION);
73 } 73 }
74 74
75 void WrapContentsInDummySpanCommand::doReapply() 75 void WrapContentsInDummySpanCommand::doReapply()
76 { 76 {
77 ASSERT(m_element); 77 DCHECK(m_element);
78 78
79 if (!m_dummySpan || !m_element->hasEditableStyle()) 79 if (!m_dummySpan || !m_element->hasEditableStyle())
80 return; 80 return;
81 81
82 executeApply(); 82 executeApply();
83 } 83 }
84 84
85 DEFINE_TRACE(WrapContentsInDummySpanCommand) 85 DEFINE_TRACE(WrapContentsInDummySpanCommand)
86 { 86 {
87 visitor->trace(m_element); 87 visitor->trace(m_element);
88 visitor->trace(m_dummySpan); 88 visitor->trace(m_dummySpan);
89 SimpleEditCommand::trace(visitor); 89 SimpleEditCommand::trace(visitor);
90 } 90 }
91 91
92 } // namespace blink 92 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698