third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

index 670be8ed87de9e3fcf1c6d71808dcde955627659..ff5adea1597594d5ba49bbcab1da15ba8cad5c52 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

@@ -1255,11 +1255,11 @@ TEST_F(VisibleUnitsTest, startOfParagraph)

root->setInnerHTML("<style>* { display:inline-table; }</style><body contenteditable=true><svg><svg><foreignObject>abc<svg></svg></foreignObject></svg></svg></body>", ASSERT_NO_EXCEPTION);

Element* oldBody = document().body();

root->setInnerHTML("<body contenteditable=true><svg><foreignObject><style>def</style>", ASSERT_NO_EXCEPTION);

- ASSERT(oldBody != document().body());

+ DCHECK_NE(oldBody, document().body());

Node* foreignObject = document().body()->firstChild()->firstChild();

foreignObject->insertBefore(oldBody, foreignObject->firstChild());

Node* styleText = foreignObject->lastChild()->firstChild();

- ASSERT(styleText->isTextNode());

+ DCHECK(styleText->isTextNode()) << styleText;

updateLayoutAndStyleForPainting();

EXPECT_FALSE(startOfParagraph(createVisiblePosition(Position(styleText, 0))).isNull());