third_party/WebKit/Source/core/editing/EphemeralRange.h - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EphemeralRange.h

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EphemeralRange.h

diff --git a/third_party/WebKit/Source/core/editing/EphemeralRange.h b/third_party/WebKit/Source/core/editing/EphemeralRange.h

index 945f0e336a3655991d1f0709a3c97df83076b3b8..ad357fb8c0dab2b2d6cd56444600133e83fae8d7 100644

--- a/third_party/WebKit/Source/core/editing/EphemeralRange.h

+++ b/third_party/WebKit/Source/core/editing/EphemeralRange.h

@@ -60,7 +60,7 @@ public:

bool isCollapsed() const;

bool isNull() const

{

- ASSERT(isValid());

+ DCHECK(isValid());

return m_startPosition.isNull();

}

bool isNotNull() const { return !isNull(); }