third_party/WebKit/Source/core/editing/PlainTextRange.h - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/PlainTextRange.h

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/PlainTextRange.h

diff --git a/third_party/WebKit/Source/core/editing/PlainTextRange.h b/third_party/WebKit/Source/core/editing/PlainTextRange.h

index eacfe4a499c95e52b5091719c7b880c806ab7e53..0988510dd54f1a4313e50654f0baf74d7f1404d0 100644

--- a/third_party/WebKit/Source/core/editing/PlainTextRange.h

+++ b/third_party/WebKit/Source/core/editing/PlainTextRange.h

@@ -46,11 +46,11 @@ public:

explicit PlainTextRange(int location);

PlainTextRange(int start, int end);

- size_t end() const { ASSERT(!isNull()); return m_end; }

- size_t start() const { ASSERT(!isNull()); return m_start; }

+ size_t end() const { DCHECK(isNotNull()); return m_end; }

+ size_t start() const { DCHECK(isNotNull()); return m_start; }

bool isNull() const { return m_start == kNotFound; }

bool isNotNull() const { return m_start != kNotFound; }

- size_t length() const { ASSERT(!isNull()); return m_end - m_start; }

+ size_t length() const { DCHECK(isNotNull()); return m_end - m_start; }

EphemeralRange createRange(const ContainerNode& scope) const;

EphemeralRange createRangeForSelection(const ContainerNode& scope) const;