Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/core/editing/PendingSelection.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/PendingSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/PendingSelection.cpp b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
index 02afe9e71686bba20f36d895c9b836a3013cc6ef..a3a42151e0c1b7afc0a8e0c372280a8143cd6f4c 100644
--- a/third_party/WebKit/Source/core/editing/PendingSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
@@ -86,7 +86,7 @@ void PendingSelection::commit(LayoutView& layoutView)
{
if (!hasPendingSelection())
return;
- ASSERT(!layoutView.needsLayout());
+ DCHECK(!layoutView.needsLayout());
m_hasPendingSelection = false;
const VisibleSelectionInFlatTree& originalSelection = m_frameSelection->visibleSelection<EditingInFlatTreeStrategy>();
@@ -130,7 +130,8 @@ void PendingSelection::commit(LayoutView& layoutView)
LayoutObject* endLayoutObject = endPos.anchorNode()->layoutObject();
if (!startLayoutObject || !endLayoutObject)
return;
- ASSERT(layoutView == startLayoutObject->view() && layoutView == endLayoutObject->view());
+ DCHECK(layoutView == startLayoutObject->view());
+ DCHECK(layoutView == endLayoutObject->view());
layoutView.setSelection(startLayoutObject, startPos.computeEditingOffset(), endLayoutObject, endPos.computeEditingOffset());
}

Powered by Google App Engine
This is Rietveld 408576698