Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1970)

Unified Diff: third_party/WebKit/Source/core/editing/Position.h

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.h
diff --git a/third_party/WebKit/Source/core/editing/Position.h b/third_party/WebKit/Source/core/editing/Position.h
index 8c6d909ee9d94c481a0185d7cd7a074cb3eda716..a00d20ba4a4c7bd12434b0dd8b6e06124f78faa0 100644
--- a/third_party/WebKit/Source/core/editing/Position.h
+++ b/third_party/WebKit/Source/core/editing/Position.h
@@ -100,7 +100,7 @@ public:
// Inline O(1) access for Positions which callers know to be parent-anchored
int offsetInContainerNode() const
{
- ASSERT(isOffsetInAnchor());
+ DCHECK(isOffsetInAnchor());
return m_offset;
}
@@ -240,10 +240,10 @@ bool operator!=(const PositionTemplate<Strategy>& a, const PositionTemplate<Stra
template <typename Strategy>
PositionTemplate<Strategy> PositionTemplate<Strategy>::inParentBeforeNode(const Node& node)
{
- // FIXME: This should ASSERT(node.parentNode())
+ // FIXME: This should DCHECK(node.parentNode())
// At least one caller currently hits this ASSERT though, which indicates
// that the caller is trying to make a position relative to a disconnected node (which is likely an error)
- // Specifically, editing/deleting/delete-ligature-001.html crashes with ASSERT(node->parentNode())
+ // Specifically, editing/deleting/delete-ligature-001.html crashes with DCHECK(node->parentNode())
return PositionTemplate<Strategy>(Strategy::parent(node), Strategy::index(node));
}
@@ -255,7 +255,7 @@ inline Position positionInParentBeforeNode(const Node& node)
template <typename Strategy>
PositionTemplate<Strategy> PositionTemplate<Strategy>::inParentAfterNode(const Node& node)
{
- ASSERT(node.parentNode());
+ DCHECK(node.parentNode()) << node;
return PositionTemplate<Strategy>(Strategy::parent(node), Strategy::index(node) + 1);
}
@@ -268,7 +268,7 @@ inline Position positionInParentAfterNode(const Node& node)
template <typename Strategy>
PositionTemplate<Strategy> PositionTemplate<Strategy>::beforeNode(Node* anchorNode)
{
- ASSERT(anchorNode);
+ DCHECK(anchorNode);
return PositionTemplate<Strategy>(anchorNode, PositionAnchorType::BeforeAnchor);
}
@@ -280,7 +280,7 @@ inline Position positionBeforeNode(Node* anchorNode)
template <typename Strategy>
PositionTemplate<Strategy> PositionTemplate<Strategy>::afterNode(Node* anchorNode)
{
- ASSERT(anchorNode);
+ DCHECK(anchorNode);
return PositionTemplate<Strategy>(anchorNode, PositionAnchorType::AfterAnchor);
}

Powered by Google App Engine
This is Rietveld 408576698