third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp b/third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp

index ebcab4b573e4315acb278c3c4a26d1353e7ea0b4..5750eb69fef6797551f8beacceefa9d728070713 100644

--- a/third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp

@@ -34,11 +34,11 @@ AppendNodeCommand::AppendNodeCommand(ContainerNode* parent, Node* node)

, m_parent(parent)

, m_node(node)

{

- ASSERT(m_parent);

- ASSERT(m_node);

- ASSERT(!m_node->parentNode());

+ DCHECK(m_parent);

+ DCHECK(m_node);

+ DCHECK(!m_node->parentNode()) << m_node;

- ASSERT(m_parent->hasEditableStyle() || !m_parent->inActiveDocument());

+ DCHECK(m_parent->hasEditableStyle() || !m_parent->inActiveDocument()) << m_parent;

}

void AppendNodeCommand::doApply(EditingState*)