Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: third_party/WebKit/Source/core/editing/Editor.h

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 TriState state(Event* triggeringEvent = nullptr) const; 135 TriState state(Event* triggeringEvent = nullptr) const;
136 String value(Event* triggeringEvent = nullptr) const; 136 String value(Event* triggeringEvent = nullptr) const;
137 137
138 bool isTextInsertion() const; 138 bool isTextInsertion() const;
139 139
140 // Returns 0 if this Command is not supported. 140 // Returns 0 if this Command is not supported.
141 int idForHistogram() const; 141 int idForHistogram() const;
142 private: 142 private:
143 LocalFrame& frame() const 143 LocalFrame& frame() const
144 { 144 {
145 ASSERT(m_frame); 145 DCHECK(m_frame);
146 return *m_frame; 146 return *m_frame;
147 } 147 }
148 148
149 const EditorInternalCommand* m_command; 149 const EditorInternalCommand* m_command;
150 EditorCommandSource m_source; 150 EditorCommandSource m_source;
151 Member<LocalFrame> m_frame; 151 Member<LocalFrame> m_frame;
152 }; 152 };
153 Command createCommand(const String& commandName); // Command source is Comma ndFromMenuOrKeyBinding. 153 Command createCommand(const String& commandName); // Command source is Comma ndFromMenuOrKeyBinding.
154 Command createCommand(const String& commandName, EditorCommandSource); 154 Command createCommand(const String& commandName, EditorCommandSource);
155 155
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 const OwnPtr<KillRing> m_killRing; 254 const OwnPtr<KillRing> m_killRing;
255 VisibleSelection m_mark; 255 VisibleSelection m_mark;
256 bool m_areMarkedTextMatchesHighlighted; 256 bool m_areMarkedTextMatchesHighlighted;
257 EditorParagraphSeparator m_defaultParagraphSeparator; 257 EditorParagraphSeparator m_defaultParagraphSeparator;
258 bool m_overwriteModeEnabled; 258 bool m_overwriteModeEnabled;
259 259
260 explicit Editor(LocalFrame&); 260 explicit Editor(LocalFrame&);
261 261
262 LocalFrame& frame() const 262 LocalFrame& frame() const
263 { 263 {
264 ASSERT(m_frame); 264 DCHECK(m_frame);
265 return *m_frame; 265 return *m_frame;
266 } 266 }
267 267
268 bool canDeleteRange(const EphemeralRange&) const; 268 bool canDeleteRange(const EphemeralRange&) const;
269 bool shouldDeleteRange(const EphemeralRange&) const; 269 bool shouldDeleteRange(const EphemeralRange&) const;
270 270
271 UndoStack* undoStack() const; 271 UndoStack* undoStack() const;
272 272
273 bool tryDHTMLCopy(); 273 bool tryDHTMLCopy();
274 bool tryDHTMLCut(); 274 bool tryDHTMLCut();
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 309
310 inline bool Editor::markedTextMatchesAreHighlighted() const 310 inline bool Editor::markedTextMatchesAreHighlighted() const
311 { 311 {
312 return m_areMarkedTextMatchesHighlighted; 312 return m_areMarkedTextMatchesHighlighted;
313 } 313 }
314 314
315 315
316 } // namespace blink 316 } // namespace blink
317 317
318 #endif // Editor_h 318 #endif // Editor_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698