Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index e1d2f0fe18572803afa15c40bfe7af59a60e36ee..e0bec0d04b7f7e5410c475b8e79a6102a73e6c87 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -285,7 +285,7 @@ void InputMethodController::setComposition(const String& text, const Vector<Comp
// If text is empty, then delete the old composition here. If text is non-empty, InsertTextCommand::input
// will delete the old composition with an optimized replace operation.
if (text.isEmpty()) {
- ASSERT(frame().document());
+ DCHECK(frame().document());
TypingCommand::deleteSelection(*frame().document(), TypingCommand::PreventSpellChecking);
}
@@ -293,7 +293,7 @@ void InputMethodController::setComposition(const String& text, const Vector<Comp
if (text.isEmpty())
return;
- ASSERT(frame().document());
+ DCHECK(frame().document());
TypingCommand::insertText(*frame().document(), text, TypingCommand::SelectInsertedText | TypingCommand::PreventSpellChecking, TypingCommand::TextCompositionUpdate);
// Find out what node has the composition now.
@@ -400,7 +400,7 @@ PlainTextRange InputMethodController::getSelectionOffsets() const
if (range.isNull())
return PlainTextRange();
ContainerNode* editable = frame().selection().rootEditableElementOrTreeScopeRootNode();
- ASSERT(editable);
+ DCHECK(editable);
return PlainTextRange::create(*editable, range);
}

Powered by Google App Engine
This is Rietveld 408576698