Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
diff --git a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
index 4f73fcef59f951a24e692e461dc37baca26f1b1d..aca53794f5b40a4846bb5beae38a556f34de6d0f 100644
--- a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
+++ b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
@@ -83,7 +83,7 @@ int CharacterIteratorAlgorithm<Strategy>::startOffset() const
if (!m_textIterator.atEnd()) {
if (m_textIterator.length() > 1)
return m_textIterator.startOffsetInCurrentContainer() + m_runOffset;
- ASSERT(!m_runOffset);
+ DCHECK(!m_runOffset);
}
return m_textIterator.startOffsetInCurrentContainer();
}
@@ -94,7 +94,7 @@ int CharacterIteratorAlgorithm<Strategy>::endOffset() const
if (!m_textIterator.atEnd()) {
if (m_textIterator.length() > 1)
return m_textIterator.startOffsetInCurrentContainer() + m_runOffset + 1;
- ASSERT(!m_runOffset);
+ DCHECK(!m_runOffset);
}
return m_textIterator.endOffsetInCurrentContainer();
}
@@ -108,7 +108,7 @@ PositionTemplate<Strategy> CharacterIteratorAlgorithm<Strategy>::startPosition()
int offset = m_textIterator.startOffsetInCurrentContainer() + m_runOffset;
return PositionTemplate<Strategy>::editingPositionOf(n, offset);
}
- ASSERT(!m_runOffset);
+ DCHECK(!m_runOffset);
}
return m_textIterator.startPositionInCurrentContainer();
}
@@ -122,7 +122,7 @@ PositionTemplate<Strategy> CharacterIteratorAlgorithm<Strategy>::endPosition() c
int offset = m_textIterator.startOffsetInCurrentContainer() + m_runOffset;
return PositionTemplate<Strategy>::editingPositionOf(n, offset + 1);
}
- ASSERT(!m_runOffset);
+ DCHECK(!m_runOffset);
}
return m_textIterator.endPositionInCurrentContainer();
}
@@ -131,7 +131,7 @@ template <typename Strategy>
void CharacterIteratorAlgorithm<Strategy>::advance(int count)
{
if (count <= 0) {
- ASSERT(!count);
+ DCHECK(!count);
return;
}

Powered by Google App Engine
This is Rietveld 408576698