ASSERT -> DCHECK in core/editing.

third_party/WebKit/Source/core/editing/DOMSelection.cpp

 /*
  * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 32 matching lines @@
 #include "core/editing/iterators/TextIterator.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/UseCounter.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 static Position createPosition(Node* node, int offset)
 {
-    ASSERT(offset >= 0);
+    DCHECK_GE(offset, 0);
     if (!node)
         return Position();
     return Position(node, offset);
 }
 
 static Node* selectionShadowAncestor(LocalFrame* frame)
 {
     Node* node = frame->selection().selection().base().anchorNode();
     if (!node)
         return 0;
@@ skipping 10 matching lines @@
 {
 }
 
 void DOMSelection::clearTreeScope()
 {
     m_treeScope = nullptr;
 }
 
 const VisibleSelection& DOMSelection::visibleSelection() const
 {
-    ASSERT(m_frame);
+    DCHECK(m_frame);
     return m_frame->selection().selection();
 }
 
 static Position anchorPosition(const VisibleSelection& selection)
 {
     Position anchor = selection.isBaseFirst() ? selection.start() : selection.end();
     return anchor.parentAnchoredEquivalent();
 }
 
 static Position focusPosition(const VisibleSelection& selection)
@@ skipping 244 matching lines @@
     else if (equalIgnoringCase(granularityString, "documentboundary"))
         granularity = DocumentBoundary;
     else
         return;
 
     m_frame->selection().modify(alter, direction, granularity);
 }
 
 void DOMSelection::extend(Node* node, int offset, ExceptionState& exceptionState)
 {
-    ASSERT(node);
+    DCHECK(node);
 
     if (!m_frame)
         return;
 
     if (offset < 0) {
         exceptionState.throwDOMException(IndexSizeError, String::number(offset) + " is not a valid offset.");
         return;
     }
     if (static_cast<unsigned>(offset) > node->lengthOfContents()) {
         exceptionState.throwDOMException(IndexSizeError, String::number(offset) + " is larger than the given node's length.");
@@ skipping 10 matching lines @@
 {
     if (!m_frame)
         return nullptr;
 
     if (index < 0 || index >= rangeCount()) {
         exceptionState.throwDOMException(IndexSizeError, String::number(index) + " is not a valid index.");
         return nullptr;
     }
 
     // If you're hitting this, you've added broken multi-range selection support
-    ASSERT(rangeCount() == 1);
+    DCHECK_EQ(rangeCount(), 1);
 
     Position anchor = anchorPosition(visibleSelection());
     if (!anchor.anchorNode()->isInShadowTree())
         return m_frame->selection().firstRange();
 
     Node* node = shadowAdjustedNode(anchor);
     if (!node) // crbug.com/595100
         return nullptr;
     if (!visibleSelection().isBaseFirst())
         return Range::create(*anchor.document(), focusNode(), focusOffset(), node, anchorOffset());
     return Range::create(*anchor.document(), node, anchorOffset(), focusNode(), focusOffset());
 }
 
 void DOMSelection::removeAllRanges()
 {
     if (!m_frame)
         return;
     m_frame->selection().clear();
 }
 
 void DOMSelection::addRange(Range* newRange)
 {
-    ASSERT(newRange);
+    DCHECK(newRange);
 
     if (!m_frame)
         return;
 
     if (!newRange->inShadowIncludingDocument()) {
         addConsoleError("The given range isn't in document.");
         return;
     }
 
     FrameSelection& selection = m_frame->selection();
@@ skipping 46 matching lines @@
     if (!selectedRange)
         return;
 
     selectedRange->deleteContents(ASSERT_NO_EXCEPTION);
 
     setBaseAndExtent(selectedRange->startContainer(), selectedRange->startOffset(), selectedRange->startContainer(), selectedRange->startOffset(), ASSERT_NO_EXCEPTION);
 }
 
 bool DOMSelection::containsNode(const Node* n, bool allowPartial) const
 {
-    ASSERT(n);
+    DCHECK(n);
 
     if (!m_frame)
         return false;
 
     FrameSelection& selection = m_frame->selection();
 
     if (m_frame->document() != n->document() || selection.isNone())
         return false;
 
     unsigned nodeIndex = n->nodeIndex();
     const EphemeralRange selectedRange = selection.selection().toNormalizedEphemeralRange();
 
     ContainerNode* parentNode = n->parentNode();
     if (!parentNode)
         return false;
 
     const Position startPosition = selectedRange.startPosition().toOffsetInAnchor();
     const Position endPosition = selectedRange.endPosition().toOffsetInAnchor();
     TrackExceptionState exceptionState;
     bool nodeFullySelected = Range::compareBoundaryPoints(parentNode, nodeIndex, startPosition.computeContainerNode(), startPosition.offsetInContainerNode(), exceptionState) >= 0 && !exceptionState.hadException()
         && Range::compareBoundaryPoints(parentNode, nodeIndex + 1, endPosition.computeContainerNode(), endPosition.offsetInContainerNode(), exceptionState) <= 0 && !exceptionState.hadException();
     if (exceptionState.hadException())
         return false;
     if (nodeFullySelected)
         return true;
 
     bool nodeFullyUnselected = (Range::compareBoundaryPoints(parentNode, nodeIndex, endPosition.computeContainerNode(), endPosition.offsetInContainerNode(), exceptionState) > 0 && !exceptionState.hadException())
         || (Range::compareBoundaryPoints(parentNode, nodeIndex + 1, startPosition.computeContainerNode(), startPosition.offsetInContainerNode(), exceptionState) < 0 && !exceptionState.hadException());
-    ASSERT(!exceptionState.hadException());
+    DCHECK(!exceptionState.hadException());
     if (nodeFullyUnselected)
         return false;
 
     return allowPartial || n->isTextNode();
 }
 
 void DOMSelection::selectAllChildren(Node* n, ExceptionState& exceptionState)
 {
-    ASSERT(n);
+    DCHECK(n);
 
     // This doesn't (and shouldn't) select text node characters.
     setBaseAndExtent(n, 0, n, n->countChildren(), exceptionState);
 }
 
 String DOMSelection::toString()
 {
     if (!m_frame)
         return String();
 
     const EphemeralRange range = m_frame->selection().selection().toNormalizedEphemeralRange();
     return plainText(range, TextIteratorForSelectionToString);
 }
 
 Node* DOMSelection::shadowAdjustedNode(const Position& position) const
 {
     if (position.isNull())
         return 0;
 
     Node* containerNode = position.computeContainerNode();
     Node* adjustedNode = m_treeScope->ancestorInThisScope(containerNode);
 
     if (!adjustedNode)
         return 0;
 
     if (containerNode == adjustedNode)
         return containerNode;
 
-    ASSERT(!adjustedNode->isShadowRoot());
+    DCHECK(!adjustedNode->isShadowRoot());

[yosin_UTC9, 2016/04/14 04:34:59]

How about adding |adjustedNode|?

     return adjustedNode->parentOrShadowHostNode();
 }
 
 int DOMSelection::shadowAdjustedOffset(const Position& position) const
 {
     if (position.isNull())
         return 0;
 
     Node* containerNode = position.computeContainerNode();
     Node* adjustedNode = m_treeScope->ancestorInThisScope(containerNode);
 
     if (!adjustedNode)
         return 0;
 
     if (containerNode == adjustedNode)
         return position.computeOffsetInContainerNode();
 
     return adjustedNode->nodeIndex();
 }
 
 bool DOMSelection::isValidForPosition(Node* node) const
 {
-    ASSERT(m_frame);
+    DCHECK(m_frame);
     if (!node)
         return true;
     return node->document() == m_frame->document();
 }
 
 void DOMSelection::addConsoleError(const String& message)
 {
     if (m_treeScope)
         m_treeScope->document().addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
 DEFINE_TRACE(DOMSelection)
 {
     visitor->trace(m_treeScope);
     DOMWindowProperty::trace(visitor);
 }
 
 } // namespace blink