Componentize IDS_NEW_TAB_* & IDS_SAD_TAB_* string to share on iOS.

Componentize IDS_NEW_TAB_* & IDS_SAD_TAB_* string to share on iOS.

TBR=thakis@chromium.org
BUG=568486
Committed: https://crrev.com/957f4a7e1c0d080416046ab562e510c2ec6e685b
Cr-Commit-Position: refs/heads/master@{#376151}

[sdefresne, 2016-02-17 17:17:10]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2016-02-17 17:17:10]

Please take a look.

[droger, 2016-02-17 17:39:39]

lgtm

[sdefresne, 2016-02-18 10:44:13]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2016-02-18 10:44:13]

thakis: TBR for OWNERS stamp for the following files
  chrome/browser/memory_details.cc
  chrome/browser/search/local_ntp_source.cc
  chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
  chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
  chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
  chrome/browser/ui/search/search_tab_helper.cc
  chrome/browser/ui/search/search_tab_helper_unittest.cc
  chrome/browser/ui/tab_contents/core_tab_helper.cc
  chrome/browser/ui/views/sad_tab_view.cc
  chrome/browser/ui/webui/ntp/new_tab_ui.cc
  chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

[sdefresne, 2016-02-18 12:35:46]

Description was changed from

==========
Componentize IDS_NEW_TAB_* & IDS_SAD_TAB_* string to share on iOS.

BUG=568486
==========

to

==========
Componentize IDS_NEW_TAB_* & IDS_SAD_TAB_* string to share on iOS.

TBR=thakis@chromium.org
BUG=568486
==========

[sdefresne, 2016-02-18 12:36:09]

TBR-ing thakis as the changes are trivial (addition of some #include)

[sdefresne, 2016-02-18 12:36:12]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-02-18 12:36:12]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1705823002/#ps20001
(title: "Copy IDS_NEW_TAB_TITLE translation to components_strings_*.xtb to fix
browser_tests")

[commit-bot: I haz the power, 2016-02-18 12:37:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705823002/20001

[commit-bot: I haz the power, 2016-02-18 12:44:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 12:45:52]

Description was changed from

==========
Componentize IDS_NEW_TAB_* & IDS_SAD_TAB_* string to share on iOS.

TBR=thakis@chromium.org
BUG=568486
==========

to

==========
Componentize IDS_NEW_TAB_* & IDS_SAD_TAB_* string to share on iOS.

TBR=thakis@chromium.org
BUG=568486

Committed: https://crrev.com/957f4a7e1c0d080416046ab562e510c2ec6e685b
Cr-Commit-Position: refs/heads/master@{#376151}
==========

[commit-bot: I haz the power, 2016-02-18 12:45:54]

Patchset 2 (id:??) landed as
https://crrev.com/957f4a7e1c0d080416046ab562e510c2ec6e685b
Cr-Commit-Position: refs/heads/master@{#376151}

[Nico, 2016-02-18 14:14:45]

chrome/ lgtm

Why does components/ have the translated versions checked in but chrome doesn't?

[sdefresne, 2016-02-18 15:07:56]

On 2016/02/18 at 14:14:45, thakis wrote:
> chrome/ lgtm
> 
> Why does components/ have the translated versions checked in but chrome
doesn't?

Oh, forgot to update the description when I did the change.

There's one test LocalNTPTest.NTPRespectsBrowserLanguageSetting that loads the
"fr" datapack and compare the new tab title with a hard-coded value (see
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...).
I think this is bad as it would break if the French translation ever change,
however I didn't want to change the test in that CL (as I assumed there was a
good reason for the test to be written that way).

So, the have the test pass, I did copy the translated string to the
components/strings/components_strings_${locale}.xtb file. Usually the string
would be automatically be added to the .xtb as part of the localisation dump
process and that is why we do not have to copy them when moving string from one
.grd file to another. I did not remove it from
chrome/app/resources/generated_resources_${locale}.xtb as the tool does not mind
if there are obsolete translations in the .xtb file, and because they will be
removed as part of the next localization dump.

TL;DR: I did copy the string to copy a test hard-coding the "fr" translation of
IDS_NEW_TAB_TITLE to "Nouvel Onglet".