Componentize IDS_SESSION_CRASHED_* to allow sharing with iOS.

Componentize IDS_SESSION_CRASHED_* to allow sharing with iOS.

BUG=568486
Committed: https://crrev.com/32064a7461f2846007bcdb4558f4dd11177e3022
Cr-Commit-Position: refs/heads/master@{#376136}

[sdefresne, 2016-02-17 16:13:55]

sdefresne@chromium.org changed reviewers:
+ pkasting@chromium.org

[sdefresne, 2016-02-17 16:13:55]

Please take a look.

[sdefresne, 2016-02-17 16:25:13]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2016-02-17 16:25:13]

+droger: Please take a look.

[droger, 2016-02-17 17:40:46]

lgtm

[Peter Kasting, 2016-02-17 22:14:20]

LGTM with substantive question

https://codereview.chromium.org/1708593002/diff/1/components/sessions_strings...
File components/sessions_strings.grdp (right):

https://codereview.chromium.org/1708593002/diff/1/components/sessions_strings...
components/sessions_strings.grdp:7: <if expr="_google_chrome">
Is this the pattern we've been using elsewhere?  I'm concerned that it's not
parallel to the "one file per differently-named port" solution, primarily since
I don't understand enough about why that solution was implemented to know if
this poses problems for other Chromium-based named products or something.  Did
the l10n people sign off on this methodology?

[sdefresne, 2016-02-18 09:34:22]

https://codereview.chromium.org/1708593002/diff/1/components/sessions_strings...
File components/sessions_strings.grdp (right):

https://codereview.chromium.org/1708593002/diff/1/components/sessions_strings...
components/sessions_strings.grdp:7: <if expr="_google_chrome">
On 2016/02/17 at 22:14:20, Peter Kasting wrote:
> Is this the pattern we've been using elsewhere?  I'm concerned that it's not
parallel to the "one file per differently-named port" solution, primarily since
I don't understand enough about why that solution was implemented to know if
this poses problems for other Chromium-based named products or something.  Did
the l10n people sign off on this methodology?

Actually, components strings currently uses both. See
components/components_chromium_strings.grd &
components/components_google_chrome_strings.grd. Moved the branded string to
those files instead (since as you pointed out this is better for other products
based on Chromium).

[sdefresne, 2016-02-18 10:12:21]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-02-18 10:12:21]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1708593002/#ps20001
(title: "Move branded strings to components_$(branding).grd")

[commit-bot: I haz the power, 2016-02-18 10:12:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708593002/20001

[commit-bot: I haz the power, 2016-02-18 10:42:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 10:43:18]

Description was changed from

==========
Componentize IDS_SESSION_CRASHED_* to allow sharing with iOS.

BUG=568486
==========

to

==========
Componentize IDS_SESSION_CRASHED_* to allow sharing with iOS.

BUG=568486

Committed: https://crrev.com/32064a7461f2846007bcdb4558f4dd11177e3022
Cr-Commit-Position: refs/heads/master@{#376136}
==========

[commit-bot: I haz the power, 2016-02-18 10:43:19]

Patchset 2 (id:??) landed as
https://crrev.com/32064a7461f2846007bcdb4558f4dd11177e3022
Cr-Commit-Position: refs/heads/master@{#376136}