Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed)

Created:
7 years, 6 months ago by brettw
Modified:
7 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews, felt, tzik+watch_chromium.org, yoshiki+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, markusheintz_, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, albertb+watch_chromium.org, haitaol+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, yurys, davidbarr+watch_chromium.org, aboxhall+watch_chromium.org, eroman, mmenke, dtseng+watch_chromium.org, cc-bugs_chromium.org, rsimha+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Convert most of extensions and some other random stuff to using the base namespace for Values. R=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207937

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1098 lines, -1019 lines) Patch
M cc/base/math_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/activity_log/api_actions.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/api_actions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/app_runtime/app_runtime_api.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/audio/audio_api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 13 chunks +28 lines, -26 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 7 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service_new.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/commands/commands.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/context_menus/context_menus_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dns/dns_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/execute_code_function.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/execute_code_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 7 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/web_auth_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity_private/identity_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 31 chunks +37 lines, -37 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_helpers.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 16 chunks +31 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 15 chunks +39 lines, -35 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc View 25 chunks +49 lines, -46 lines 1 comment Download
M chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/record/record_api_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_api.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/setting_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_backend.cc View 7 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_quota_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_processor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_test_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.cc View 6 chunks +28 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.h View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 10 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_interactive_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/tabs/windows_event_router.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/test/test_api.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/test/test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/top_sites/top_sites_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc View 5 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/webview/webview_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webview/webview_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_window_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 19 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/event_listener_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_listener_map_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_router_forwarder.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/event_router_forwarder_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_function.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extensions_quota_service.h View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extensions_quota_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extensions_quota_service_unittest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/media_galleries_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/menu_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/policy_map.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/scoped_user_pref_update.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/value_store/value_store.h View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M chrome/tools/build/generate_policy_source.py View 5 chunks +10 lines, -10 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_manager_client_stub.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/certificate_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/cros_network_functions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/device_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_ui_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_merger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_protocol.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/media/webrtc_internals_message_handler.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gaia/google_service_auth_error.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M jingle/glue/utils.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M media/base/media_log_event.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_log.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/cert/crl_set.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/dns/dns_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_netlog_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M printing/page_size_margins.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_change_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M sync/api/sync_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/engine/traffic_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/engine/traffic_recorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/traffic_recorder.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M sync/engine/traffic_recorder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/base_node.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/internal_api/change_record.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/js_mutation_event_observer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/js_sync_encryption_handler_observer.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/base/invalidation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/base/model_type_invalidation_map.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/base/model_type_invalidation_map_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/base/progress_marker_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/change_record_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/engine/model_safe_worker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/sessions/sync_source_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/sessions/sync_source_info_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/js/js_arg_list.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/js/js_arg_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/js/js_event_details.h View 1 chunk +4 lines, -3 lines 0 comments Download
M sync/js/js_event_details.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M sync/js/js_event_details_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/js/js_test_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/object_id_invalidation_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/notifier/p2p_invalidator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M sync/protocol/proto_value_conversions_unittest.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M sync/protocol/sync_protocol_error.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/sync_protocol_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/entry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/entry_kernel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/model_type_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/syncable/nigori_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/test/accounts_client/test_accounts_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/util.h View 4 chunks +16 lines, -14 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ui/webui/jstemplate_builder.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/webui/web_ui_util.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/webui/web_ui_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
TBR=finnur
7 years, 6 months ago (2013-06-21 20:37:43 UTC) #1
Finnur
Man, I had to read this patch line for line to make sure you weren't ...
7 years, 6 months ago (2013-06-21 21:25:00 UTC) #2
brettw
Committed patchset #2 manually as r207937.
7 years, 6 months ago (2013-06-21 22:34:49 UTC) #3
brettw
7 years, 6 months ago (2013-06-21 22:41:27 UTC) #4
Thanks!

On Fri, Jun 21, 2013 at 3:34 PM,  <brettw@chromium.org> wrote:
> Committed patchset #2 manually as r207937.
>
> https://codereview.chromium.org/16915006/

Powered by Google App Engine
This is Rietveld 408576698