chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.h ('k') | chrome/browser/extensions/api/streams_private/streams_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc

diff --git a/chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc b/chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc

index 7adf5f4b749b1a4125085d9359f6e815deb75fe1..241ae2f5d2ecb334e58df6f41f12cf345f055750 100644

--- a/chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc

+++ b/chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc

@@ -41,12 +41,12 @@ ValueStore::ReadResult WeakUnlimitedSettingsStorage::Get() {

}

ValueStore::WriteResult WeakUnlimitedSettingsStorage::Set(

- WriteOptions options, const std::string& key, const Value& value) {

+ WriteOptions options, const std::string& key, const base::Value& value) {

return delegate_->Set(IGNORE_QUOTA, key, value);

}

ValueStore::WriteResult WeakUnlimitedSettingsStorage::Set(

- WriteOptions options, const DictionaryValue& values) {

+ WriteOptions options, const base::DictionaryValue& values) {

return delegate_->Set(IGNORE_QUOTA, values);

}