Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3771)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
index f08390631ce9a2e3ea92633ef6c27fa2332d5b6c..480bb94190063f348d29008523863389c65477d3 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
@@ -216,10 +216,10 @@ net::NetLog::ParametersCallback CreateNetLogExtensionIdCallback(
Value* NetLogModificationCallback(
const EventResponseDelta* delta,
net::NetLog::LogLevel log_level) {
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetString("extension_id", delta->extension_id);
- ListValue* modified_headers = new ListValue();
+ base::ListValue* modified_headers = new base::ListValue();
net::HttpRequestHeaders::Iterator modification(
delta->modified_request_headers);
while (modification.GetNext()) {
@@ -228,7 +228,7 @@ Value* NetLogModificationCallback(
}
dict->Set("modified_headers", modified_headers);
- ListValue* deleted_headers = new ListValue();
+ base::ListValue* deleted_headers = new base::ListValue();
for (std::vector<std::string>::const_iterator key =
delta->deleted_request_headers.begin();
key != delta->deleted_request_headers.end();
@@ -245,8 +245,8 @@ bool InDecreasingExtensionInstallationTimeOrder(
return a->extension_install_time > b->extension_install_time;
}
-ListValue* StringToCharList(const std::string& s) {
- ListValue* result = new ListValue;
+base::ListValue* StringToCharList(const std::string& s) {
+ base::ListValue* result = new base::ListValue;
for (size_t i = 0, n = s.size(); i < n; ++i) {
result->Append(
Value::CreateIntegerValue(
@@ -255,7 +255,7 @@ ListValue* StringToCharList(const std::string& s) {
return result;
}
-bool CharListToString(const ListValue* list, std::string* out) {
+bool CharListToString(const base::ListValue* list, std::string* out) {
if (!list)
return false;
const size_t list_length = list->GetSize();

Powered by Google App Engine
This is Rietveld 408576698