chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

index 28096a1be5c8af5daab96e8d7a2b2d6df4c04042..888e2a78e75165115dae488ddb7bebb3d37f9171 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

@@ -332,7 +332,7 @@ void RulesRegistryWithCache::RuleStorageOnUI::WriteToStorage(

if (!profile_)

return;

- const ListValue* rules = NULL;

+ const base::ListValue* rules = NULL;

CHECK(value->GetAsList(&rules));

bool rules_stored_previously = GetDeclarativeRulesStored(extension_id);

bool store_rules = !rules->empty();