chrome/browser/extensions/api/messaging/message_service.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/message_service.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc ('k') | chrome/browser/extensions/api/notifications/notifications_api.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/message_service.cc

diff --git a/chrome/browser/extensions/api/messaging/message_service.cc b/chrome/browser/extensions/api/messaging/message_service.cc

index 3d0576611ff29d85e82c4f7e3906b1390f76bc10..6ef2531ba9891e9b155c85b55f1616b599b3d504 100644

--- a/chrome/browser/extensions/api/messaging/message_service.cc

+++ b/chrome/browser/extensions/api/messaging/message_service.cc

@@ -70,7 +70,7 @@ struct MessageService::MessageChannel {

struct MessageService::OpenChannelParams {

content::RenderProcessHost* source;

- DictionaryValue source_tab;

+ base::DictionaryValue source_tab;

scoped_ptr<MessagePort> receiver;

int receiver_port_id;

std::string source_extension_id;

@@ -80,7 +80,7 @@ struct MessageService::OpenChannelParams {

// Takes ownership of receiver.

OpenChannelParams(content::RenderProcessHost* source,

- scoped_ptr<DictionaryValue> source_tab,

+ scoped_ptr<base::DictionaryValue> source_tab,

MessagePort* receiver,

int receiver_port_id,

const std::string& source_extension_id,

@@ -240,7 +240,7 @@ void MessageService::OpenChannelToExtension(

source_process_id, source_routing_id);

// Include info about the opener's tab (if it was a tab).

- scoped_ptr<DictionaryValue> source_tab;

+ scoped_ptr<base::DictionaryValue> source_tab;

GURL source_url_for_tab;

if (source_contents && ExtensionTabUtil::GetTabId(source_contents) >= 0) {

@@ -355,8 +355,8 @@ void MessageService::OpenChannelToTab(

scoped_ptr<OpenChannelParams> params(new OpenChannelParams(

source,

- scoped_ptr<DictionaryValue>(), // Source tab doesn't make sense for

- // opening to tabs.

+ scoped_ptr<base::DictionaryValue>(), // Source tab doesn't make sense

+ // for opening to tabs.

receiver.release(),

receiver_port_id,

extension_id,