chrome/browser/extensions/extension_special_storage_policy_unittest.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_tab_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

index 3ae4143614deb126f18c9edbb16f534cc1afa47a..7e0705278a9c3761afbc59f694ff726d2709dbf8 100644

--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

@@ -104,7 +104,7 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {

manifest.SetString(keys::kName, "Protected");

manifest.SetString(keys::kVersion, "1");

manifest.SetString(keys::kLaunchWebURL, "http://explicit/protected/start");

- ListValue* list = new ListValue();

+ base::ListValue* list = new base::ListValue();

list->Append(Value::CreateStringValue("http://explicit/protected"));

list->Append(Value::CreateStringValue("*://*.wildcards/protected"));

manifest.Set(keys::kWebURLs, list);

@@ -126,10 +126,10 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {

manifest.SetString(keys::kName, "Unlimited");

manifest.SetString(keys::kVersion, "1");

manifest.SetString(keys::kLaunchWebURL, "http://explicit/unlimited/start");

- ListValue* list = new ListValue();

+ base::ListValue* list = new base::ListValue();

list->Append(Value::CreateStringValue("unlimitedStorage"));

manifest.Set(keys::kPermissions, list);

- list = new ListValue();

+ list = new base::ListValue();

list->Append(Value::CreateStringValue("http://explicit/unlimited"));

list->Append(Value::CreateStringValue("*://*.wildcards/unlimited"));

manifest.Set(keys::kWebURLs, list);