chrome/browser/extensions/api/cookies/cookies_helpers.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/extensions/api/cookies/cookies_unittest.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cookies/cookies_helpers.cc

diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

index fe1f01f35fe02a45069ff3485282ab779aff2b5f..c151c9278bcb15074f92a785bc04de18d7d7891e 100644

--- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc

+++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

@@ -90,10 +90,10 @@ scoped_ptr<Cookie> CreateCookie(

}

scoped_ptr<CookieStore> CreateCookieStore(Profile* profile,

- ListValue* tab_ids) {

+ base::ListValue* tab_ids) {

DCHECK(profile);

DCHECK(tab_ids);

- DictionaryValue dict;

+ base::DictionaryValue dict;

dict.SetString(keys::kIdKey, GetStoreIdFromProfile(profile));

dict.Set(keys::kTabIdsKey, tab_ids);

@@ -146,7 +146,7 @@ void AppendMatchingCookiesToVector(const net::CookieList& all_cookies,

}

-void AppendToTabIdList(Browser* browser, ListValue* tab_ids) {

+void AppendToTabIdList(Browser* browser, base::ListValue* tab_ids) {

DCHECK(browser);

DCHECK(tab_ids);

TabStripModel* tab_strip = browser->tab_strip_model();