chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/fullstream_ui_policy.cc ('k') | chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

index ebbfd832d2caed366f068422370b3654b9d4bcf4..2f3de4adb4ea56a80f14f5c6791b72a38477ca60 100644

--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

@@ -98,7 +98,7 @@ TEST_F(FullStreamUIPolicyTest, Construct) {

.Set("manifest_version", 2))

.Build();

extension_service_->AddExtension(extension);

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

policy->ProcessAction(ActivityLogPolicy::ACTION_API, extension->id(),

std::string("tabs.testMethod"), GURL(), args.get(), NULL);

}

@@ -113,7 +113,7 @@ TEST_F(FullStreamUIPolicyTest, LogAndFetchActions) {

.Set("manifest_version", 2))

.Build();

extension_service_->AddExtension(extension);

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

GURL gurl("http://www.google.com");

// Write some API calls

@@ -136,7 +136,7 @@ TEST_F(FullStreamUIPolicyTest, LogWithArguments) {

.Set("manifest_version", 2))

.Build();

extension_service_->AddExtension(extension);

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

args->Set(0, new base::StringValue("hello"));

args->Set(1, new base::StringValue("world"));

policy->ProcessAction(ActivityLogPolicy::ACTION_API, extension->id(),