chrome/browser/extensions/activity_log/activity_log_unittest.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Unified Diff: chrome/browser/extensions/activity_log/activity_log_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log.cc ('k') | chrome/browser/extensions/activity_log/api_actions.h » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_log_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_unittest.cc

index 64b7d4da5011ff5c8486fa0a2d0fc9728334e5cb..01bdcd140e2dfea9cb62a9fa5ec58ef9fd42fb59 100644

--- a/chrome/browser/extensions/activity_log/activity_log_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_log_unittest.cc

@@ -188,7 +188,7 @@ TEST_F(ActivityLogTest, Enabled) {

TEST_F(ActivityLogTest, Construct) {

ActivityLog* activity_log = ActivityLog::GetInstance(profile_.get());

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

ASSERT_TRUE(activity_log->IsLogEnabled());

activity_log->LogAPIAction(

kExtensionId, std::string("tabs.testMethod"), args.get(), std::string());

@@ -196,7 +196,7 @@ TEST_F(ActivityLogTest, Construct) {

TEST_F(ActivityLogTest, LogAndFetchActions) {

ActivityLog* activity_log = ActivityLog::GetInstance(profile_.get());

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

ASSERT_TRUE(activity_log->IsLogEnabled());

// Write some API calls

@@ -217,7 +217,7 @@ TEST_F(ActivityLogTest, LogAndFetchActions) {

TEST_F(ActivityLogTest, LogAndFetchPathActions) {

ActivityLog* activity_log = ActivityLog::GetInstance(profile_.get());

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

ASSERT_TRUE(activity_log->IsLogEnabled());

activity_log->LogDOMAction(kExtensionId,

@@ -238,7 +238,7 @@ TEST_F(ActivityLogTest, LogWithoutArguments) {

activity_log->SetArgumentLoggingForTesting(false);

ASSERT_TRUE(activity_log->IsLogEnabled());

activity_log->SetDefaultPolicy(ActivityLogPolicy::POLICY_NOARGS);

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

args->Set(0, new base::StringValue("hello"));

args->Set(1, new base::StringValue("world"));

activity_log->LogAPIAction(

@@ -252,7 +252,7 @@ TEST_F(ActivityLogTest, LogWithArguments) {

activity_log->SetDefaultPolicy(ActivityLogPolicy::POLICY_FULLSTREAM);

ASSERT_TRUE(activity_log->IsLogEnabled());

- scoped_ptr<ListValue> args(new ListValue());

+ scoped_ptr<base::ListValue> args(new base::ListValue());

args->Set(0, new base::StringValue("hello"));

args->Set(1, new base::StringValue("world"));

activity_log->LogAPIAction(kExtensionId,