Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: chrome/browser/extensions/activity_log/activity_log.h

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log.h
diff --git a/chrome/browser/extensions/activity_log/activity_log.h b/chrome/browser/extensions/activity_log/activity_log.h
index 423de346f1d9f1d80a592023539295e5981c3d58..fd9b6e2a6f2c57eb0272f26d92581cfc0ff0ad4b 100644
--- a/chrome/browser/extensions/activity_log/activity_log.h
+++ b/chrome/browser/extensions/activity_log/activity_log.h
@@ -70,7 +70,7 @@ class ActivityLog : public BrowserContextKeyedService,
// (Note: implemented as a wrapper for LogAPIActionInternal.)
void LogAPIAction(const std::string& extension_id,
const std::string& name, // e.g., tabs.get
- ListValue* args, // the argument values e.g. 46
+ base::ListValue* args, // the argument values e.g. 46
const std::string& extra); // any extra logging info
// Log an event notification delivered to an extension.
@@ -78,14 +78,14 @@ class ActivityLog : public BrowserContextKeyedService,
// (Note: implemented as a wrapper for LogAPIActionInternal.)
void LogEventAction(const std::string& extension_id,
const std::string& name, // e.g., tabs.onUpdate
- ListValue* args, // arguments to the callback
+ base::ListValue* args, // arguments to the callback
const std::string& extra); // any extra logging info
// Log a blocked API call made by an extension.
// This will create a BlockedAction for storage in the database.
void LogBlockedAction(const std::string& extension_id,
const std::string& blocked_call, // e.g., tabs.get
- ListValue* args, // argument values
+ base::ListValue* args, // argument values
BlockedAction::Reason reason, // why it's blocked
const std::string& extra); // extra logging info
@@ -95,7 +95,7 @@ class ActivityLog : public BrowserContextKeyedService,
const GURL& url, // target URL
const string16& url_title, // title of the URL
const std::string& api_call, // api call
- const ListValue* args, // arguments
+ const base::ListValue* args, // arguments
DomActionType::Type call_type, // type of the call
const std::string& extra); // extra logging info
@@ -168,7 +168,7 @@ class ActivityLog : public BrowserContextKeyedService,
void LogAPIActionInternal(
const std::string& extension_id,
const std::string& api_call,
- ListValue* args,
+ base::ListValue* args,
const std::string& extra,
const APIAction::Type type);

Powered by Google App Engine
This is Rietveld 408576698