chrome/browser/extensions/activity_log/api_actions.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/api_actions.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/api_actions.h ('k') | chrome/browser/extensions/activity_log/fullstream_ui_policy.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/api_actions.cc

diff --git a/chrome/browser/extensions/activity_log/api_actions.cc b/chrome/browser/extensions/activity_log/api_actions.cc

index c1b4fe77a7796629193ae3ecfba8ccf8926ac452..483d394eca769d8744cd3d6b546fb679901fdaaa 100644

--- a/chrome/browser/extensions/activity_log/api_actions.cc

+++ b/chrome/browser/extensions/activity_log/api_actions.cc

@@ -208,7 +208,7 @@ bool APIAction::Record(sql::Connection* db) {

// static

void APIAction::LookupTabId(const std::string& api_call,

- ListValue* args,

+ base::ListValue* args,

Profile* profile) {

if (api_call == "tabs.get" || // api calls, ID as int

api_call == "tabs.connect" ||

@@ -228,7 +228,7 @@ void APIAction::LookupTabId(const std::string& api_call,

api_call == "tabs.onRemoved" ||

api_call == "tabs.onReplaced") {

int tab_id;

- ListValue* id_list;

+ base::ListValue* id_list;

if (args->GetInteger(0, &tab_id)) {

std::string url = GetURLForTabId(tab_id, profile);

if (url != std::string())