Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/browser/extensions/convert_web_app.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/convert_web_app.h" 5 #include "chrome/browser/extensions/convert_web_app.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <limits> 8 #include <limits>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 DictionaryValue* icons = new DictionaryValue(); 123 DictionaryValue* icons = new DictionaryValue();
124 root->Set(keys::kIcons, icons); 124 root->Set(keys::kIcons, icons);
125 for (size_t i = 0; i < web_app.icons.size(); ++i) { 125 for (size_t i = 0; i < web_app.icons.size(); ++i) {
126 std::string size = base::StringPrintf("%i", web_app.icons[i].width); 126 std::string size = base::StringPrintf("%i", web_app.icons[i].width);
127 std::string icon_path = base::StringPrintf("%s/%s.png", kIconsDirName, 127 std::string icon_path = base::StringPrintf("%s/%s.png", kIconsDirName,
128 size.c_str()); 128 size.c_str());
129 icons->SetString(size, icon_path); 129 icons->SetString(size, icon_path);
130 } 130 }
131 131
132 // Add the permissions. 132 // Add the permissions.
133 ListValue* permissions = new ListValue(); 133 base::ListValue* permissions = new base::ListValue();
134 root->Set(keys::kPermissions, permissions); 134 root->Set(keys::kPermissions, permissions);
135 for (size_t i = 0; i < web_app.permissions.size(); ++i) { 135 for (size_t i = 0; i < web_app.permissions.size(); ++i) {
136 permissions->Append(Value::CreateStringValue(web_app.permissions[i])); 136 permissions->Append(Value::CreateStringValue(web_app.permissions[i]));
137 } 137 }
138 138
139 // Add the URLs. 139 // Add the URLs.
140 ListValue* urls = new ListValue(); 140 base::ListValue* urls = new base::ListValue();
141 root->Set(keys::kWebURLs, urls); 141 root->Set(keys::kWebURLs, urls);
142 for (size_t i = 0; i < web_app.urls.size(); ++i) { 142 for (size_t i = 0; i < web_app.urls.size(); ++i) {
143 urls->Append(Value::CreateStringValue(web_app.urls[i].spec())); 143 urls->Append(Value::CreateStringValue(web_app.urls[i].spec()));
144 } 144 }
145 145
146 // Write the manifest. 146 // Write the manifest.
147 base::FilePath manifest_path = temp_dir.path().Append(kManifestFilename); 147 base::FilePath manifest_path = temp_dir.path().Append(kManifestFilename);
148 JSONFileValueSerializer serializer(manifest_path); 148 JSONFileValueSerializer serializer(manifest_path);
149 if (!serializer.Serialize(*root)) { 149 if (!serializer.Serialize(*root)) {
150 LOG(ERROR) << "Could not serialize manifest."; 150 LOG(ERROR) << "Could not serialize manifest.";
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 if (!extension.get()) { 193 if (!extension.get()) {
194 LOG(ERROR) << error; 194 LOG(ERROR) << error;
195 return NULL; 195 return NULL;
196 } 196 }
197 197
198 temp_dir.Take(); // The caller takes ownership of the directory. 198 temp_dir.Take(); // The caller takes ownership of the directory.
199 return extension; 199 return extension;
200 } 200 }
201 201
202 } // namespace extensions 202 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698