Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/browser/extensions/api/top_sites/top_sites_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/top_sites/top_sites_api.h" 5 #include "chrome/browser/extensions/api/top_sites/top_sites_api.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/history/top_sites.h" 9 #include "chrome/browser/history/top_sites.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 12 matching lines...) Expand all
23 return false; 23 return false;
24 24
25 ts->GetMostVisitedURLs( 25 ts->GetMostVisitedURLs(
26 base::Bind(&TopSitesGetFunction::OnMostVisitedURLsAvailable, 26 base::Bind(&TopSitesGetFunction::OnMostVisitedURLsAvailable,
27 weak_ptr_factory_.GetWeakPtr())); 27 weak_ptr_factory_.GetWeakPtr()));
28 return true; 28 return true;
29 } 29 }
30 30
31 void TopSitesGetFunction::OnMostVisitedURLsAvailable( 31 void TopSitesGetFunction::OnMostVisitedURLsAvailable(
32 const history::MostVisitedURLList& data) { 32 const history::MostVisitedURLList& data) {
33 scoped_ptr<base::ListValue> pages_value(new ListValue); 33 scoped_ptr<base::ListValue> pages_value(new base::ListValue);
34 for (size_t i = 0; i < data.size(); i++) { 34 for (size_t i = 0; i < data.size(); i++) {
35 const history::MostVisitedURL& url = data[i]; 35 const history::MostVisitedURL& url = data[i];
36 if (!url.url.is_empty()) { 36 if (!url.url.is_empty()) {
37 DictionaryValue* page_value = new DictionaryValue(); 37 base::DictionaryValue* page_value = new base::DictionaryValue();
38 page_value->SetString("url", url.url.spec()); 38 page_value->SetString("url", url.url.spec());
39 if (url.title.empty()) 39 if (url.title.empty())
40 page_value->SetString("title", url.url.spec()); 40 page_value->SetString("title", url.url.spec());
41 else 41 else
42 page_value->SetString("title", url.title); 42 page_value->SetString("title", url.title);
43 pages_value->Append(page_value); 43 pages_value->Append(page_value);
44 } 44 }
45 } 45 }
46 46
47 SetResult(pages_value.release()); 47 SetResult(pages_value.release());
48 SendResponse(true); 48 SendResponse(true);
49 } 49 }
50 50
51 } // namespace extensions 51 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698