chrome/browser/extensions/api/cookies/cookies_unittest.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cookies/cookies_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cookies/cookies_unittest.cc

diff --git a/chrome/browser/extensions/api/cookies/cookies_unittest.cc b/chrome/browser/extensions/api/cookies/cookies_unittest.cc

index 172ed31bb9906b2c31456dd35078639fb0f5758d..f5f15236d350ca8db7574d0b2ab5f05250e79e5d 100644

--- a/chrome/browser/extensions/api/cookies/cookies_unittest.cc

+++ b/chrome/browser/extensions/api/cookies/cookies_unittest.cc

@@ -143,7 +143,7 @@ TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {

EXPECT_EQ(10000, *cookie2->expiration_date);

TestingProfile profile;

- ListValue* tab_ids_list = new ListValue();

+ base::ListValue* tab_ids_list = new base::ListValue();

std::vector<int> tab_ids;

scoped_ptr<CookieStore> cookie_store(

cookies_helpers::CreateCookieStore(&profile, tab_ids_list));

@@ -168,7 +168,7 @@ TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) {

}

TEST_F(ExtensionCookiesTest, EmptyDictionary) {

- DictionaryValue dict;

+ base::DictionaryValue dict;

GetAll::Params::Details details;

bool rv = GetAll::Params::Details::Populate(dict, &details);

ASSERT_TRUE(rv);

@@ -190,8 +190,8 @@ TEST_F(ExtensionCookiesTest, DomainMatching) {

for (size_t i = 0; i < arraysize(tests); ++i) {

// Build up the Params struct.

- ListValue args;

- DictionaryValue* dict = new DictionaryValue();

+ base::ListValue args;

+ base::DictionaryValue* dict = new base::DictionaryValue();

dict->SetString(keys::kDomainKey, std::string(tests[i].filter));

args.Set(0, dict);

scoped_ptr<GetAll::Params> params(GetAll::Params::Create(args));