Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Side by Side Diff: chrome/browser/extensions/extensions_quota_service_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop.h" 5 #include "base/message_loop.h"
6 #include "base/process.h" 6 #include "base/process.h"
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "chrome/browser/extensions/extension_function.h" 9 #include "chrome/browser/extensions/extension_function.h"
10 #include "chrome/browser/extensions/extensions_quota_service.h" 10 #include "chrome/browser/extensions/extensions_quota_service.h"
(...skipping 16 matching lines...) Expand all
27 const Config kFrozenConfig = { 0, TimeDelta::FromDays(0) }; 27 const Config kFrozenConfig = { 0, TimeDelta::FromDays(0) };
28 const Config k2PerMinute = { 2, TimeDelta::FromMinutes(1) }; 28 const Config k2PerMinute = { 2, TimeDelta::FromMinutes(1) };
29 const Config k20PerHour = { 20, TimeDelta::FromHours(1) }; 29 const Config k20PerHour = { 20, TimeDelta::FromHours(1) };
30 const TimeTicks kStartTime = TimeTicks(); 30 const TimeTicks kStartTime = TimeTicks();
31 const TimeTicks k1MinuteAfterStart = kStartTime + TimeDelta::FromMinutes(1); 31 const TimeTicks k1MinuteAfterStart = kStartTime + TimeDelta::FromMinutes(1);
32 32
33 class Mapper : public QuotaLimitHeuristic::BucketMapper { 33 class Mapper : public QuotaLimitHeuristic::BucketMapper {
34 public: 34 public:
35 Mapper() {} 35 Mapper() {}
36 virtual ~Mapper() { STLDeleteValues(&buckets_); } 36 virtual ~Mapper() { STLDeleteValues(&buckets_); }
37 virtual void GetBucketsForArgs(const ListValue* args, 37 virtual void GetBucketsForArgs(const base::ListValue* args,
38 BucketList* buckets) OVERRIDE { 38 BucketList* buckets) OVERRIDE {
39 for (size_t i = 0; i < args->GetSize(); i++) { 39 for (size_t i = 0; i < args->GetSize(); i++) {
40 int id; 40 int id;
41 ASSERT_TRUE(args->GetInteger(i, &id)); 41 ASSERT_TRUE(args->GetInteger(i, &id));
42 if (buckets_.find(id) == buckets_.end()) 42 if (buckets_.find(id) == buckets_.end())
43 buckets_[id] = new Bucket(); 43 buckets_[id] = new Bucket();
44 buckets->push_back(buckets_[id]); 44 buckets->push_back(buckets_[id]);
45 } 45 }
46 } 46 }
47 private: 47 private:
48 typedef std::map<int, Bucket*> BucketMap; 48 typedef std::map<int, Bucket*> BucketMap;
49 BucketMap buckets_; 49 BucketMap buckets_;
50 DISALLOW_COPY_AND_ASSIGN(Mapper); 50 DISALLOW_COPY_AND_ASSIGN(Mapper);
51 }; 51 };
52 52
53 class MockMapper : public QuotaLimitHeuristic::BucketMapper { 53 class MockMapper : public QuotaLimitHeuristic::BucketMapper {
54 public: 54 public:
55 virtual void GetBucketsForArgs(const ListValue* args, 55 virtual void GetBucketsForArgs(const base::ListValue* args,
56 BucketList* buckets) OVERRIDE { 56 BucketList* buckets) OVERRIDE {
57 } 57 }
58 }; 58 };
59 59
60 class MockFunction : public ExtensionFunction { 60 class MockFunction : public ExtensionFunction {
61 public: 61 public:
62 explicit MockFunction(const std::string& name) { set_name(name); } 62 explicit MockFunction(const std::string& name) { set_name(name); }
63 63
64 virtual void SetArgs(const ListValue* args) OVERRIDE {} 64 virtual void SetArgs(const base::ListValue* args) OVERRIDE {}
65 virtual const std::string GetError() OVERRIDE { return std::string(); } 65 virtual const std::string GetError() OVERRIDE { return std::string(); }
66 virtual void SetError(const std::string& error) OVERRIDE {} 66 virtual void SetError(const std::string& error) OVERRIDE {}
67 virtual void Run() OVERRIDE {} 67 virtual void Run() OVERRIDE {}
68 virtual void Destruct() const OVERRIDE { delete this; } 68 virtual void Destruct() const OVERRIDE { delete this; }
69 virtual bool RunImpl() OVERRIDE { return true; } 69 virtual bool RunImpl() OVERRIDE { return true; }
70 virtual void SendResponse(bool) OVERRIDE { } 70 virtual void SendResponse(bool) OVERRIDE { }
71 71
72 protected: 72 protected:
73 virtual ~MockFunction() {} 73 virtual ~MockFunction() {}
74 }; 74 };
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 210
211 // Do the same as above except don't exhaust the 3rd (w.l.o.g) bucket. 211 // Do the same as above except don't exhaust the 3rd (w.l.o.g) bucket.
212 bucket.Reset(k2PerMinute, kStartTime); 212 bucket.Reset(k2PerMinute, kStartTime);
213 DoMoreThan2PerMinuteFor5Minutes(kStartTime, &lim, &bucket, 3); 213 DoMoreThan2PerMinuteFor5Minutes(kStartTime, &lim, &bucket, 3);
214 // If the 3rd bucket were exhausted, this would fail (see first test). 214 // If the 3rd bucket were exhausted, this would fail (see first test).
215 EXPECT_TRUE(lim.Apply(&bucket, kStartTime + TimeDelta::FromMinutes(6))); 215 EXPECT_TRUE(lim.Apply(&bucket, kStartTime + TimeDelta::FromMinutes(6)));
216 } 216 }
217 217
218 TEST_F(ExtensionsQuotaServiceTest, NoHeuristic) { 218 TEST_F(ExtensionsQuotaServiceTest, NoHeuristic) {
219 scoped_refptr<MockFunction> f(new MockFunction("foo")); 219 scoped_refptr<MockFunction> f(new MockFunction("foo"));
220 ListValue args; 220 base::ListValue args;
221 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args, kStartTime)); 221 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args, kStartTime));
222 } 222 }
223 223
224 TEST_F(ExtensionsQuotaServiceTest, FrozenHeuristic) { 224 TEST_F(ExtensionsQuotaServiceTest, FrozenHeuristic) {
225 scoped_refptr<MockFunction> f(new FrozenMockFunction("foo")); 225 scoped_refptr<MockFunction> f(new FrozenMockFunction("foo"));
226 ListValue args; 226 base::ListValue args;
227 args.Append(new base::FundamentalValue(1)); 227 args.Append(new base::FundamentalValue(1));
228 EXPECT_NE("", service_->Assess(extension_a_, f.get(), &args, kStartTime)); 228 EXPECT_NE("", service_->Assess(extension_a_, f.get(), &args, kStartTime));
229 } 229 }
230 230
231 TEST_F(ExtensionsQuotaServiceTest, SingleHeuristic) { 231 TEST_F(ExtensionsQuotaServiceTest, SingleHeuristic) {
232 scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo")); 232 scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo"));
233 ListValue args; 233 base::ListValue args;
234 args.Append(new base::FundamentalValue(1)); 234 args.Append(new base::FundamentalValue(1));
235 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args, kStartTime)); 235 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args, kStartTime));
236 EXPECT_EQ("", 236 EXPECT_EQ("",
237 service_->Assess(extension_a_, 237 service_->Assess(extension_a_,
238 f.get(), 238 f.get(),
239 &args, 239 &args,
240 kStartTime + TimeDelta::FromSeconds(10))); 240 kStartTime + TimeDelta::FromSeconds(10)));
241 EXPECT_NE("", 241 EXPECT_NE("",
242 service_->Assess(extension_a_, 242 service_->Assess(extension_a_,
243 f.get(), 243 f.get(),
244 &args, 244 &args,
245 kStartTime + TimeDelta::FromSeconds(15))); 245 kStartTime + TimeDelta::FromSeconds(15)));
246 246
247 ListValue args2; 247 base::ListValue args2;
248 args2.Append(new base::FundamentalValue(1)); 248 args2.Append(new base::FundamentalValue(1));
249 args2.Append(new base::FundamentalValue(2)); 249 args2.Append(new base::FundamentalValue(2));
250 EXPECT_EQ("", service_->Assess(extension_b_, f.get(), &args2, kStartTime)); 250 EXPECT_EQ("", service_->Assess(extension_b_, f.get(), &args2, kStartTime));
251 EXPECT_EQ("", 251 EXPECT_EQ("",
252 service_->Assess(extension_b_, 252 service_->Assess(extension_b_,
253 f.get(), 253 f.get(),
254 &args2, 254 &args2,
255 kStartTime + TimeDelta::FromSeconds(10))); 255 kStartTime + TimeDelta::FromSeconds(10)));
256 256
257 TimeDelta peace = TimeDelta::FromMinutes(30); 257 TimeDelta peace = TimeDelta::FromMinutes(30);
258 EXPECT_EQ("", 258 EXPECT_EQ("",
259 service_->Assess(extension_b_, f.get(), &args, kStartTime + peace)); 259 service_->Assess(extension_b_, f.get(), &args, kStartTime + peace));
260 EXPECT_EQ("", 260 EXPECT_EQ("",
261 service_->Assess(extension_b_, 261 service_->Assess(extension_b_,
262 f.get(), 262 f.get(),
263 &args, 263 &args,
264 kStartTime + peace + TimeDelta::FromSeconds(10))); 264 kStartTime + peace + TimeDelta::FromSeconds(10)));
265 EXPECT_NE("", 265 EXPECT_NE("",
266 service_->Assess(extension_b_, 266 service_->Assess(extension_b_,
267 f.get(), 267 f.get(),
268 &args2, 268 &args2,
269 kStartTime + peace + TimeDelta::FromSeconds(15))); 269 kStartTime + peace + TimeDelta::FromSeconds(15)));
270 270
271 // Test that items are independent. 271 // Test that items are independent.
272 ListValue args3; 272 base::ListValue args3;
273 args3.Append(new base::FundamentalValue(3)); 273 args3.Append(new base::FundamentalValue(3));
274 EXPECT_EQ("", service_->Assess(extension_c_, f.get(), &args, kStartTime)); 274 EXPECT_EQ("", service_->Assess(extension_c_, f.get(), &args, kStartTime));
275 EXPECT_EQ("", 275 EXPECT_EQ("",
276 service_->Assess(extension_c_, 276 service_->Assess(extension_c_,
277 f.get(), 277 f.get(),
278 &args3, 278 &args3,
279 kStartTime + TimeDelta::FromSeconds(10))); 279 kStartTime + TimeDelta::FromSeconds(10)));
280 EXPECT_EQ("", 280 EXPECT_EQ("",
281 service_->Assess(extension_c_, 281 service_->Assess(extension_c_,
282 f.get(), 282 f.get(),
(...skipping 11 matching lines...) Expand all
294 kStartTime + TimeDelta::FromSeconds(25))); 294 kStartTime + TimeDelta::FromSeconds(25)));
295 EXPECT_NE("", 295 EXPECT_NE("",
296 service_->Assess(extension_c_, 296 service_->Assess(extension_c_,
297 f.get(), 297 f.get(),
298 &args3, 298 &args3,
299 kStartTime + TimeDelta::FromSeconds(30))); 299 kStartTime + TimeDelta::FromSeconds(30)));
300 } 300 }
301 301
302 TEST_F(ExtensionsQuotaServiceTest, ChainedHeuristics) { 302 TEST_F(ExtensionsQuotaServiceTest, ChainedHeuristics) {
303 scoped_refptr<MockFunction> f(new ChainedLimitsMockFunction("foo")); 303 scoped_refptr<MockFunction> f(new ChainedLimitsMockFunction("foo"));
304 ListValue args; 304 base::ListValue args;
305 args.Append(new base::FundamentalValue(1)); 305 args.Append(new base::FundamentalValue(1));
306 306
307 // First, test that the low limit can be avoided but the higher one is hit. 307 // First, test that the low limit can be avoided but the higher one is hit.
308 // One event per minute for 20 minutes comes in under the sustained limit, 308 // One event per minute for 20 minutes comes in under the sustained limit,
309 // but is equal to the timed limit. 309 // but is equal to the timed limit.
310 for (int i = 0; i < 20; i++) { 310 for (int i = 0; i < 20; i++) {
311 EXPECT_EQ( 311 EXPECT_EQ(
312 "", 312 "",
313 service_->Assess(extension_a_, 313 service_->Assess(extension_a_,
314 f.get(), 314 f.get(),
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 service_->Assess(extension_b_, 349 service_->Assess(extension_b_,
350 f.get(), 350 f.get(),
351 &args, 351 &args,
352 kStartTime + TimeDelta::FromMinutes(6))); 352 kStartTime + TimeDelta::FromMinutes(6)));
353 } 353 }
354 354
355 TEST_F(ExtensionsQuotaServiceTest, MultipleFunctionsDontInterfere) { 355 TEST_F(ExtensionsQuotaServiceTest, MultipleFunctionsDontInterfere) {
356 scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo")); 356 scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo"));
357 scoped_refptr<MockFunction> g(new TimedLimitMockFunction("bar")); 357 scoped_refptr<MockFunction> g(new TimedLimitMockFunction("bar"));
358 358
359 ListValue args_f; 359 base::ListValue args_f;
360 ListValue args_g; 360 base::ListValue args_g;
361 args_f.Append(new base::FundamentalValue(1)); 361 args_f.Append(new base::FundamentalValue(1));
362 args_g.Append(new base::FundamentalValue(2)); 362 args_g.Append(new base::FundamentalValue(2));
363 363
364 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args_f, kStartTime)); 364 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args_f, kStartTime));
365 EXPECT_EQ("", service_->Assess(extension_a_, g.get(), &args_g, kStartTime)); 365 EXPECT_EQ("", service_->Assess(extension_a_, g.get(), &args_g, kStartTime));
366 EXPECT_EQ("", 366 EXPECT_EQ("",
367 service_->Assess(extension_a_, 367 service_->Assess(extension_a_,
368 f.get(), 368 f.get(),
369 &args_f, 369 &args_f,
370 kStartTime + TimeDelta::FromSeconds(10))); 370 kStartTime + TimeDelta::FromSeconds(10)));
(...skipping 10 matching lines...) Expand all
381 EXPECT_NE("", 381 EXPECT_NE("",
382 service_->Assess(extension_a_, 382 service_->Assess(extension_a_,
383 g.get(), 383 g.get(),
384 &args_g, 384 &args_g,
385 kStartTime + TimeDelta::FromSeconds(15))); 385 kStartTime + TimeDelta::FromSeconds(15)));
386 } 386 }
387 387
388 TEST_F(ExtensionsQuotaServiceTest, ViolatorsWillBeViolators) { 388 TEST_F(ExtensionsQuotaServiceTest, ViolatorsWillBeViolators) {
389 scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo")); 389 scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo"));
390 scoped_refptr<MockFunction> g(new TimedLimitMockFunction("bar")); 390 scoped_refptr<MockFunction> g(new TimedLimitMockFunction("bar"));
391 ListValue arg; 391 base::ListValue arg;
392 arg.Append(new base::FundamentalValue(1)); 392 arg.Append(new base::FundamentalValue(1));
393 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg, kStartTime)); 393 EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg, kStartTime));
394 EXPECT_EQ("", 394 EXPECT_EQ("",
395 service_->Assess(extension_a_, 395 service_->Assess(extension_a_,
396 f.get(), 396 f.get(),
397 &arg, 397 &arg,
398 kStartTime + TimeDelta::FromSeconds(10))); 398 kStartTime + TimeDelta::FromSeconds(10)));
399 EXPECT_NE("", 399 EXPECT_NE("",
400 service_->Assess(extension_a_, 400 service_->Assess(extension_a_,
401 f.get(), 401 f.get(),
402 &arg, 402 &arg,
403 kStartTime + TimeDelta::FromSeconds(15))); 403 kStartTime + TimeDelta::FromSeconds(15)));
404 404
405 // We don't allow this extension to use quota limited functions even if they 405 // We don't allow this extension to use quota limited functions even if they
406 // wait a while. 406 // wait a while.
407 EXPECT_NE( 407 EXPECT_NE(
408 "", 408 "",
409 service_->Assess( 409 service_->Assess(
410 extension_a_, f.get(), &arg, kStartTime + TimeDelta::FromDays(1))); 410 extension_a_, f.get(), &arg, kStartTime + TimeDelta::FromDays(1)));
411 EXPECT_NE( 411 EXPECT_NE(
412 "", 412 "",
413 service_->Assess( 413 service_->Assess(
414 extension_a_, g.get(), &arg, kStartTime + TimeDelta::FromDays(1))); 414 extension_a_, g.get(), &arg, kStartTime + TimeDelta::FromDays(1)));
415 } 415 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698