chromeos/network/cros_network_functions.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/cros_network_functions.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chromeos/network/certificate_pattern.cc ('k') | chromeos/network/device_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/cros_network_functions.cc

diff --git a/chromeos/network/cros_network_functions.cc b/chromeos/network/cros_network_functions.cc

index d3e52e74345977a4a74ed66ae469181f64a71062..68f3d2e290df0503c5916c763337c1305b470888 100644

--- a/chromeos/network/cros_network_functions.cc

+++ b/chromeos/network/cros_network_functions.cc

@@ -286,7 +286,7 @@ void ListIPConfigsCallback(const NetworkGetIPConfigsCallback& callback,

const base::DictionaryValue& properties) {

NetworkIPConfigVector ipconfig_vector;

std::string hardware_address;

- const ListValue* ips = NULL;

+ const base::ListValue* ips = NULL;

if (call_status != DBUS_METHOD_CALL_SUCCESS ||

!properties.GetListWithoutPathExpansion(flimflam::kIPConfigsProperty,

&ips)) {

@@ -627,7 +627,7 @@ bool CrosListIPConfigsAndBlock(const std::string& device_path,

if (!properties.get())

return false;

- ListValue* ips = NULL;

+ base::ListValue* ips = NULL;

if (!properties->GetListWithoutPathExpansion(

flimflam::kIPConfigsProperty, &ips))

return false;