chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index cf02cef8a4648c64e875f67eea8a74c4f894ee22..49bdf218fa89c60805798a9a9ef98ea52e7ee119 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -234,7 +234,7 @@ TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

// 2. Test writing behavior.

int write_count = store->write_count();

- scoped_ptr<base::ListValue> value(new ListValue);

+ scoped_ptr<base::ListValue> value(new base::ListValue);

value->AppendBoolean(true);

ui_part->WriteToStorage(extension_id, value.PassAs<base::Value>());

EXPECT_TRUE(ui_part->GetDeclarativeRulesStored(extension_id));

@@ -242,7 +242,7 @@ TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

EXPECT_EQ(write_count + 1, store->write_count());

write_count = store->write_count();

- value.reset(new ListValue);

+ value.reset(new base::ListValue);

ui_part->WriteToStorage(extension_id, value.PassAs<base::Value>());

EXPECT_FALSE(ui_part->GetDeclarativeRulesStored(extension_id));

message_loop_.RunUntilIdle();

@@ -250,7 +250,7 @@ TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

EXPECT_EQ(write_count + 1, store->write_count());

write_count = store->write_count();

- value.reset(new ListValue);

+ value.reset(new base::ListValue);

ui_part->WriteToStorage(extension_id, value.PassAs<base::Value>());

EXPECT_FALSE(ui_part->GetDeclarativeRulesStored(extension_id));

message_loop_.RunUntilIdle();