google_apis/gaia/gaia_oauth_client.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_oauth_client.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « google_apis/gaia/gaia_auth_fetcher.cc ('k') | google_apis/gaia/google_service_auth_error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gaia/gaia_oauth_client.cc

diff --git a/google_apis/gaia/gaia_oauth_client.cc b/google_apis/gaia/gaia_oauth_client.cc

index 7b543db881e19979e6a74758c545ab7e3e33addd..f748fdb78ffbfd3e332de5a66a8eaf8623ffe8db 100644

--- a/google_apis/gaia/gaia_oauth_client.cc

+++ b/google_apis/gaia/gaia_oauth_client.cc

@@ -186,15 +186,15 @@ void GaiaOAuthClient::Core::HandleResponse(

return;

}

- scoped_ptr<DictionaryValue> response_dict;

+ scoped_ptr<base::DictionaryValue> response_dict;

if (source->GetResponseCode() == net::HTTP_OK) {

std::string data;

source->GetResponseAsString(&data);

- scoped_ptr<Value> message_value(base::JSONReader::Read(data));

+ scoped_ptr<base::Value> message_value(base::JSONReader::Read(data));

if (message_value.get() &&

- message_value->IsType(Value::TYPE_DICTIONARY)) {

+ message_value->IsType(base::Value::TYPE_DICTIONARY)) {

response_dict.reset(

- static_cast<DictionaryValue*>(message_value.release()));

+ static_cast<base::DictionaryValue*>(message_value.release()));

}