Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: chrome/browser/extensions/api/dns/dns_apitest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "chrome/browser/extensions/api/dns/dns_api.h" 7 #include "chrome/browser/extensions/api/dns/dns_api.h"
8 #include "chrome/browser/extensions/api/dns/host_resolver_wrapper.h" 8 #include "chrome/browser/extensions/api/dns/host_resolver_wrapper.h"
9 #include "chrome/browser/extensions/api/dns/mock_host_resolver_creator.h" 9 #include "chrome/browser/extensions/api/dns/mock_host_resolver_creator.h"
10 #include "chrome/browser/extensions/extension_apitest.h" 10 #include "chrome/browser/extensions/extension_apitest.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 scoped_refptr<extensions::DnsResolveFunction> resolve_function( 56 scoped_refptr<extensions::DnsResolveFunction> resolve_function(
57 new extensions::DnsResolveFunction()); 57 new extensions::DnsResolveFunction());
58 scoped_refptr<extensions::Extension> empty_extension(CreateEmptyExtension()); 58 scoped_refptr<extensions::Extension> empty_extension(CreateEmptyExtension());
59 59
60 resolve_function->set_extension(empty_extension.get()); 60 resolve_function->set_extension(empty_extension.get());
61 resolve_function->set_has_callback(true); 61 resolve_function->set_has_callback(true);
62 62
63 scoped_ptr<base::Value> result(RunFunctionAndReturnSingleResult( 63 scoped_ptr<base::Value> result(RunFunctionAndReturnSingleResult(
64 resolve_function.get(), "[\"127.0.0.1\"]", browser())); 64 resolve_function.get(), "[\"127.0.0.1\"]", browser()));
65 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType()); 65 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
66 DictionaryValue *value = static_cast<DictionaryValue*>(result.get()); 66 base::DictionaryValue *value =
67 static_cast<base::DictionaryValue*>(result.get());
67 68
68 int resultCode; 69 int resultCode;
69 EXPECT_TRUE(value->GetInteger("resultCode", &resultCode)); 70 EXPECT_TRUE(value->GetInteger("resultCode", &resultCode));
70 EXPECT_EQ(net::OK, resultCode); 71 EXPECT_EQ(net::OK, resultCode);
71 72
72 std::string address; 73 std::string address;
73 EXPECT_TRUE(value->GetString("address", &address)); 74 EXPECT_TRUE(value->GetString("address", &address));
74 EXPECT_EQ("127.0.0.1", address); 75 EXPECT_EQ("127.0.0.1", address);
75 } 76 }
76 77
77 IN_PROC_BROWSER_TEST_F(DnsApiTest, DnsResolveHostname) { 78 IN_PROC_BROWSER_TEST_F(DnsApiTest, DnsResolveHostname) {
78 scoped_refptr<extensions::DnsResolveFunction> resolve_function( 79 scoped_refptr<extensions::DnsResolveFunction> resolve_function(
79 new extensions::DnsResolveFunction()); 80 new extensions::DnsResolveFunction());
80 scoped_refptr<extensions::Extension> empty_extension(CreateEmptyExtension()); 81 scoped_refptr<extensions::Extension> empty_extension(CreateEmptyExtension());
81 82
82 resolve_function->set_extension(empty_extension.get()); 83 resolve_function->set_extension(empty_extension.get());
83 resolve_function->set_has_callback(true); 84 resolve_function->set_has_callback(true);
84 85
85 std::string function_arguments("[\""); 86 std::string function_arguments("[\"");
86 function_arguments += extensions::MockHostResolverCreator::kHostname; 87 function_arguments += extensions::MockHostResolverCreator::kHostname;
87 function_arguments += "\"]"; 88 function_arguments += "\"]";
88 scoped_ptr<base::Value> result( 89 scoped_ptr<base::Value> result(
89 RunFunctionAndReturnSingleResult(resolve_function.get(), 90 RunFunctionAndReturnSingleResult(resolve_function.get(),
90 function_arguments, browser())); 91 function_arguments, browser()));
91 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType()); 92 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
92 DictionaryValue *value = static_cast<DictionaryValue*>(result.get()); 93 base::DictionaryValue *value =
94 static_cast<base::DictionaryValue*>(result.get());
93 95
94 int resultCode; 96 int resultCode;
95 EXPECT_TRUE(value->GetInteger("resultCode", &resultCode)); 97 EXPECT_TRUE(value->GetInteger("resultCode", &resultCode));
96 EXPECT_EQ(net::OK, resultCode); 98 EXPECT_EQ(net::OK, resultCode);
97 99
98 std::string address; 100 std::string address;
99 EXPECT_TRUE(value->GetString("address", &address)); 101 EXPECT_TRUE(value->GetString("address", &address));
100 EXPECT_EQ(extensions::MockHostResolverCreator::kAddress, address); 102 EXPECT_EQ(extensions::MockHostResolverCreator::kAddress, address);
101 } 103 }
102 104
103 IN_PROC_BROWSER_TEST_F(DnsApiTest, DnsExtension) { 105 IN_PROC_BROWSER_TEST_F(DnsApiTest, DnsExtension) {
104 ASSERT_TRUE(RunExtensionTest("dns/api")) << message_; 106 ASSERT_TRUE(RunExtensionTest("dns/api")) << message_;
105 } 107 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698