Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4477)

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_api.cc
diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc
index c855b831cc401773089030694e8da26cd180c341..7f980378a7f4b86883b1cb7b22fe6da393c18e36 100644
--- a/chrome/browser/extensions/api/management/management_api.cc
+++ b/chrome/browser/extensions/api/management/management_api.cc
@@ -315,13 +315,13 @@ class SafeManifestJSONParser : public UtilityProcessHostClient {
return handled;
}
- void OnJSONParseSucceeded(const ListValue& wrapper) {
+ void OnJSONParseSucceeded(const base::ListValue& wrapper) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
const Value* value = NULL;
CHECK(wrapper.Get(0, &value));
if (value->IsType(Value::TYPE_DICTIONARY))
parsed_manifest_.reset(
- static_cast<const DictionaryValue*>(value)->DeepCopy());
+ static_cast<const base::DictionaryValue*>(value)->DeepCopy());
else
error_ = keys::kManifestParseError;
@@ -358,7 +358,7 @@ class SafeManifestJSONParser : public UtilityProcessHostClient {
std::string manifest_;
// Results of parsing.
- scoped_ptr<DictionaryValue> parsed_manifest_;
+ scoped_ptr<base::DictionaryValue> parsed_manifest_;
std::string error_;
};
@@ -382,7 +382,7 @@ bool ManagementGetPermissionWarningsByManifestFunction::RunImpl() {
}
void ManagementGetPermissionWarningsByManifestFunction::OnParseSuccess(
- DictionaryValue* parsed_manifest) {
+ base::DictionaryValue* parsed_manifest) {
CHECK(parsed_manifest);
scoped_refptr<Extension> extension = Extension::Create(
@@ -676,7 +676,7 @@ void ManagementEventRouter::Observe(
DCHECK(event_name);
DCHECK(extension);
- scoped_ptr<ListValue> args(new ListValue());
+ scoped_ptr<base::ListValue> args(new base::ListValue());
if (event_name == events::kOnExtensionUninstalled) {
args->Append(Value::CreateStringValue(extension->id()));
} else {

Powered by Google App Engine
This is Rietveld 408576698