chrome/browser/extensions/api/webview/webview_api.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webview/webview_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/api/webview/webview_api.h ('k') | chrome/browser/extensions/app_window_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webview/webview_api.cc

diff --git a/chrome/browser/extensions/api/webview/webview_api.cc b/chrome/browser/extensions/api/webview/webview_api.cc

index a5be9dfe60b17d3372c1edab6f2c38619d940695..dc89e4534737de202bc903927cf1acc8f14e628b 100644

--- a/chrome/browser/extensions/api/webview/webview_api.cc

+++ b/chrome/browser/extensions/api/webview/webview_api.cc

@@ -32,7 +32,7 @@ bool WebviewExecuteCodeFunction::Init() {

if (!guest_instance_id_)

return false;

- DictionaryValue* details_value = NULL;

+ base::DictionaryValue* details_value = NULL;

if (!args_->GetDictionary(1, &details_value))

return false;

scoped_ptr<InjectDetails> details(new InjectDetails());

@@ -68,7 +68,7 @@ void WebviewExecuteScriptFunction::OnExecuteCodeFinished(

const std::string& error,

int32 on_page_id,

const GURL& on_url,

- const ListValue& result) {

+ const base::ListValue& result) {

content::RecordAction(content::UserMetricsAction("WebView.ExecuteScript"));

if (error.empty())

SetResult(result.DeepCopy());