chrome/browser/extensions/api/record/record_api_test.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/record/record_api_test.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.cc ('k') | chrome/browser/extensions/api/runtime/runtime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/record/record_api_test.cc

diff --git a/chrome/browser/extensions/api/record/record_api_test.cc b/chrome/browser/extensions/api/record/record_api_test.cc

index c276ba30ab9756c7fcf06fdf5f49916392635670..f20dfea51f5eda82d3e1f4e15ab5a3a6125bd86c 100644

--- a/chrome/browser/extensions/api/record/record_api_test.cc

+++ b/chrome/browser/extensions/api/record/record_api_test.cc

@@ -241,7 +241,7 @@ class RecordApiTest : public InProcessBrowserTest {

// Verify that the URL list of good and bad URLs was properly handled.

// Needed by several tests.

- bool VerifyURLHandling(const ListValue* result,

+ bool VerifyURLHandling(const base::ListValue* result,

const TestProcessStrategy& strategy) {

// Check that the two bad URLs are returned.

@@ -345,7 +345,7 @@ IN_PROC_BROWSER_TEST_F(RecordApiTest, MAYBE_CheckPlayback) {

// Check for return value with proper stats.

EXPECT_EQ(kTestStatistics, utils::GetString(result.get(), kStatsKey));

- ListValue* errors = NULL;

+ base::ListValue* errors = NULL;

EXPECT_TRUE(result->GetList(kErrorsKey, &errors));

EXPECT_TRUE(VerifyURLHandling(errors, strategy));

}