chromeos/network/network_state.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_state.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chromeos/network/network_connection_handler.cc ('k') | chromeos/network/network_ui_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/network_state.cc

diff --git a/chromeos/network/network_state.cc b/chromeos/network/network_state.cc

index f9342f95830c48f814bd1f5e7fe200ad110214ae..f48ea0e5cb19cff86630905902b735e076bb7e78 100644

--- a/chromeos/network/network_state.cc

+++ b/chromeos/network/network_state.cc

@@ -218,10 +218,10 @@ void NetworkState::GetProperties(base::DictionaryValue* dictionary) const {

error_);

dictionary->SetStringWithoutPathExpansion(shill::kErrorDetailsProperty,

error_details_);

- base::DictionaryValue* ipconfig_properties = new DictionaryValue;

+ base::DictionaryValue* ipconfig_properties = new base::DictionaryValue;

ipconfig_properties->SetStringWithoutPathExpansion(flimflam::kAddressProperty,

ip_address_);

- base::ListValue* name_servers = new ListValue;

+ base::ListValue* name_servers = new base::ListValue;

name_servers->AppendStrings(dns_servers_);

ipconfig_properties->SetWithoutPathExpansion(flimflam::kNameServersProperty,

name_servers);