chrome/browser/extensions/api/browsing_data/browsing_data_test.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_api.cc ('k') | chrome/browser/extensions/api/commands/command_service.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

index bdfd91854e8205b4d9032d7ef273bc894be9f5c3..376a3f1e6cbb0b9aa35be55e3ec9d87ae24c38cc 100644

--- a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

@@ -77,7 +77,8 @@ class ExtensionBrowsingDataTest : public InProcessBrowserTest,

details).ptr()));

}

- int GetAsMask(const DictionaryValue* dict, std::string path, int mask_value) {

+ int GetAsMask(const base::DictionaryValue* dict, std::string path,

+ int mask_value) {

bool result;

EXPECT_TRUE(dict->GetBoolean(path, &result)) << "for " << path;

return result ? mask_value : 0;