chrome/browser/extensions/convert_web_app.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/convert_web_app.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/convert_user_script.cc ('k') | chrome/browser/extensions/event_listener_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/convert_web_app.cc

diff --git a/chrome/browser/extensions/convert_web_app.cc b/chrome/browser/extensions/convert_web_app.cc

index 9d61a864d2e9daec8d3e94ec4ce4d77b4d02fe23..b7f2b382d4b8168b565c30e1cd0302a0bc5d2df2 100644

--- a/chrome/browser/extensions/convert_web_app.cc

+++ b/chrome/browser/extensions/convert_web_app.cc

@@ -130,14 +130,14 @@ scoped_refptr<Extension> ConvertWebAppToExtension(

}

// Add the permissions.

- ListValue* permissions = new ListValue();

+ base::ListValue* permissions = new base::ListValue();

root->Set(keys::kPermissions, permissions);

for (size_t i = 0; i < web_app.permissions.size(); ++i) {

permissions->Append(Value::CreateStringValue(web_app.permissions[i]));

}

// Add the URLs.

- ListValue* urls = new ListValue();

+ base::ListValue* urls = new base::ListValue();

root->Set(keys::kWebURLs, urls);

for (size_t i = 0; i < web_app.urls.size(); ++i) {

urls->Append(Value::CreateStringValue(web_app.urls[i].spec()));