chrome/browser/extensions/api/commands/commands.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/commands.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/commands/command_service_new.cc ('k') | chrome/browser/extensions/api/content_settings/content_settings_api.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/commands/commands.cc

diff --git a/chrome/browser/extensions/api/commands/commands.cc b/chrome/browser/extensions/api/commands/commands.cc

index ebe8bada3c6824b0deeed5efa4ee1d7bb9dcc89d..1bfe0546db27cfe3a048bfbd18c38548857b60d1 100644

--- a/chrome/browser/extensions/api/commands/commands.cc

+++ b/chrome/browser/extensions/api/commands/commands.cc

@@ -10,7 +10,7 @@ namespace {

base::DictionaryValue* CreateCommandValue(

const extensions::Command& command, bool active) {

- DictionaryValue* result = new DictionaryValue();

+ base::DictionaryValue* result = new base::DictionaryValue();

result->SetString("name", command.command_name());

result->SetString("description", command.description());

result->SetString("shortcut",

@@ -22,7 +22,7 @@ base::DictionaryValue* CreateCommandValue(

} // namespace

bool GetAllCommandsFunction::RunImpl() {

- ListValue* command_list = new ListValue();

+ base::ListValue* command_list = new base::ListValue();

extensions::CommandService* command_service =

extensions::CommandService::Get(profile_);