chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/api/web_request/web_request_api_helpers.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

diff --git a/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc b/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

index 91483c502c010680e24c4fcfdfd77983c4742d24..3e551a3ebf64374e349747d7e2992bcf0afa09fd 100644

--- a/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

+++ b/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc

@@ -171,7 +171,7 @@ void WebSocketProxyPrivateGetURLForTCPFunction::CustomFinalize() {

bool WebSocketProxyPrivateGetURLForTCPFunction::RunImpl() {

#if defined(OS_CHROMEOS)

- DictionaryValue* qualification = NULL;

+ base::DictionaryValue* qualification = NULL;

if (args_->GetDictionary(2, &qualification)) {

const char kTlsOption[] = "tls";

if (qualification->HasKey(kTlsOption)) {