Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc b/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
index f1ab1ed65221c9155d086e378835f981827b5ba7..549367f046e21c9fbf520c79a52719962efa7cc6 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
+++ b/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
@@ -41,7 +41,7 @@ void CompareClassification(const ACMatchClassifications& expected,
// + ddd
// = nmmmmndddn
TEST(ExtensionOmniboxTest, DescriptionStylesSimple) {
- scoped_ptr<ListValue> list = ListBuilder()
+ scoped_ptr<base::ListValue> list = ListBuilder()
.Append(42)
.Append(ListBuilder()
.Append(DictionaryBuilder()
@@ -72,7 +72,7 @@ TEST(ExtensionOmniboxTest, DescriptionStylesSimple) {
*params->suggest_results[0]));
// Same input, but swap the order. Ensure it still works.
- scoped_ptr<ListValue> swap_list = ListBuilder()
+ scoped_ptr<base::ListValue> swap_list = ListBuilder()
.Append(42)
.Append(ListBuilder()
.Append(DictionaryBuilder()
@@ -104,7 +104,7 @@ TEST(ExtensionOmniboxTest, DescriptionStylesSimple) {
// + dd
// = 3773unnnn66
TEST(ExtensionOmniboxTest, DescriptionStylesCombine) {
- scoped_ptr<ListValue> list = ListBuilder()
+ scoped_ptr<base::ListValue> list = ListBuilder()
.Append(42)
.Append(ListBuilder()
.Append(DictionaryBuilder()
@@ -149,7 +149,7 @@ TEST(ExtensionOmniboxTest, DescriptionStylesCombine) {
// Try moving the "dim/match" style pair at offset 9. Output should be the
// same.
- scoped_ptr<ListValue> moved_list = ListBuilder()
+ scoped_ptr<base::ListValue> moved_list = ListBuilder()
.Append(42)
.Append(ListBuilder()
.Append(DictionaryBuilder()
@@ -193,7 +193,7 @@ TEST(ExtensionOmniboxTest, DescriptionStylesCombine) {
// + ddd
// = 77777nnnnn
TEST(ExtensionOmniboxTest, DescriptionStylesCombine2) {
- scoped_ptr<ListValue> list = ListBuilder()
+ scoped_ptr<base::ListValue> list = ListBuilder()
.Append(42)
.Append(ListBuilder()
.Append(DictionaryBuilder()
@@ -242,7 +242,7 @@ TEST(ExtensionOmniboxTest, DescriptionStylesCombine2) {
// = 77777nnnnn
TEST(ExtensionOmniboxTest, DefaultSuggestResult) {
// Default suggestions should not have a content parameter.
- scoped_ptr<ListValue> list = ListBuilder()
+ scoped_ptr<base::ListValue> list = ListBuilder()
.Append(DictionaryBuilder()
.Set("description", "description")
.Set("descriptionStyles", ListBuilder()

Powered by Google App Engine
This is Rietveld 408576698